Feature/external chat #228

Neunerlei · 2025-10-29T09:22:26Z

No description provided.

# Conflicts: # app/Http/Controllers/AccessTokenController.php # app/Http/Controllers/AuthenticationController.php # app/Http/Controllers/InvitationController.php # app/Http/Controllers/ProfileController.php # app/Http/Controllers/RoomController.php # app/Http/Controllers/SearchController.php # app/Http/Controllers/StreamController.php # app/Models/Invitation.php # app/Models/Message.php # app/Models/Room.php # app/Providers/AppServiceProvider.php # app/Services/AI/AIConnectionService.php # bootstrap/app.php # composer.json # composer.lock # hawki # public/js_v2.0.1_f1/groupchat_functions.js # resources/views/layouts/home.blade.php # routes/web.php

…chat # Conflicts: # app/Http/Controllers/StreamController.php # app/Models/AiModelStatus.php # app/Providers/AppServiceProvider.php # app/Services/AI/Providers/AbstractRequest.php # app/Services/AI/Providers/Google/GoogleRequestConverter.php # app/Services/AI/Providers/Google/Request/GoogleStreamingRequest.php # app/Services/AI/Providers/OpenAi/Request/OpenAiStreamingRequest.php # app/Services/AI/Value/AiModel.php # config/model_providers.php # public/js_v2.0.1_f1/groupchat_functions.js # resources/views/layouts/home.blade.php

# Conflicts: # .env.example # app/Http/Controllers/AuthenticationController.php # app/Http/Controllers/EncryptionController.php # app/Http/Controllers/RoomController.php # app/Http/Controllers/StreamController.php # app/Models/AiModelStatus.php # app/Models/Message.php # app/Models/Room.php # app/Providers/AppServiceProvider.php # app/Services/Auth/LdapService.php # app/Services/Chat/Message/Handlers/GroupMessageHandler.php # app/Services/Chat/Room/Traits/RoomFunctions.php # app/Services/Chat/Room/Traits/RoomMembers.php # app/Services/Chat/Room/Traits/RoomMessages.php # composer.json # composer.lock # public/css_v2.1.0/apps_connect_style.css # public/js_v2.1.0/apps_confirm_functions.js # public/js_v2.1.0/encryption.js # public/js_v2.1.0/groupchat_functions.js # resources/views/layouts/home.blade.php # resources/views/modules/profile.blade.php

# Conflicts: # app/Http/Controllers/AuthenticationController.php # app/Http/Controllers/RoomController.php # app/Models/Message.php # app/Models/Room.php # app/Services/Chat/Message/Handlers/GroupMessageHandler.php # app/Services/Profile/ProfileService.php # composer.lock # public/js_v2.1.0/handshake_functions.js # routes/web.php

Co-authored-by: Neunerlei <[email protected]>

…-to-v2 # Conflicts: # package-lock.json # package.json

…-upload-size build: ensure file uploads up to 100MB (from PHP side)

…-cropperjs-to-v2 Migrate cropperjs from v1.6.2 to v2.1.0

…p-add-missing-braces fix(LDAP): add missing braces to closure

(cherry picked from commit e6bd8cf)

(cherry picked from commit 436ebad)

(cherry picked from commit 9a97fdf)

…easier to debug

Co-authored-by: Copilot <[email protected]>

…cachebuster' into feat/Martin/implement-automatic-cachebuster

…ious-fixes-2.2.1 Fix/martin/various fixes 2.2.1

…plement-automatic-cachebuster feat: impelement automatic cache buster generation

# Conflicts: # app/Http/Controllers/AuthenticationController.php # app/Http/Controllers/LoginController.php # app/Providers/AppServiceProvider.php # app/Services/Profile/ProfileService.php # bootstrap/providers.php # composer.json # public/css/apps_connect_style.css # public/js/apps_confirm_functions.js # resources/views/layouts/home.blade.php # resources/views/layouts/login.blade.php # routes/web.php

Copilot

Pull Request Overview

This PR implements external application integration support for the HAWKI platform, enabling third-party apps to connect and access user data through a secure authentication flow. The changes introduce a new keychain management system, sync logging infrastructure, and comprehensive API endpoints for external applications.

Key Changes

Implements external app connection flow with user consent mechanisms
Migrates from IndexedDB-based keychain to server-side storage with individual encrypted values
Adds sync log system for incremental and full synchronization of data to clients
Introduces storage proxy service for secure file access across internal and external contexts

Reviewed Changes

Copilot reviewed 292 out of 293 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
routes/web.php	Adds routes for external app authentication, storage proxy, sync endpoints, and keychain management
routes/api.php	Defines API endpoints for external apps with proper middleware protection
routes/channels.php	Adds broadcast channels for user-specific and all-users notifications
public/js/encryption.js	Refactors keychain from IndexedDB to server-synced encrypted values with hybrid encryption support
public/js/handshake_functions.js	Updates registration flow to use new server-side keychain initialization
app/Services/User/Keychain/*	Implements server-side keychain storage with encrypted value management
app/Services/SyncLog/*	Adds comprehensive sync log system for tracking data changes
app/Services/Storage/*	Refactors storage service with file info abstraction and proxy support
config/external_access.php	New configuration for external app access controls
database/migrations/*	Adds tables for app users, requests, keychain values, and sync logs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T09:25:42Z

resources/language/apps_en_US.json

+    "confirm": {
+      "title": "Connect :appName to HAWKI",
+      "headline": "Allow connection to application \":appName\"?",
+      "description": "Hey :name! You was send to this page, because the application \":appName\" wants to connect to your HAWKI profile (:username). This will allow the application to access your messages and chats. Please only grant access to applications you trust.",


Corrected grammar: 'You was send' should be 'You were sent'.

Copilot · 2025-10-29T09:25:43Z

resources/language/apps_de_DE.json

+        "confirm": {
+            "title": ":appName mit HAWKI verbinden",
+            "headline": "Verbindung zu Anwendung \":appName\" zulassen?",
+            "description": "Hey :name! Du bist auf dieser Seite gelandet, weil die Anwendung \":appName\" sich mit deinem HAWKI Profil (:username) verbinden möchte. Damit erlaubst du der Anwendung Zugriff auf deine Nachrichten und Chats. Bitte gib nur Anwendungen Zugriff denen du vertraust.",


Missing comma: 'Anwendungen Zugriff denen' should be 'Anwendungen Zugriff, denen' (comma before relative clause).

Copilot · 2025-10-29T09:25:43Z

app/Services/Profile/ApiTokenService.php

+                PersonalAccessTokenRemovedEvent::dispatch($user, $token);
+                $token->delete();
+            });
            $token->delete();


Duplicate token deletion: The token is deleted both inside the each callback (line 45) and again on line 47, which will cause an error on the second deletion attempt since the tokens are already deleted.

Copilot · 2025-10-29T09:25:43Z

public/js/groupchat_functions.js

    const roomKey = await keychainGet(slug);
    const aiCryptoSalt = await fetchServerSalt('AI_CRYPTO_SALT');
    const aiKey = await deriveKey(roomKey, slug, aiCryptoSalt);
+    const legacyAiKey = await deriveKey('[object CryptoKey]', slug, aiCryptoSalt);


Hardcoded string '[object CryptoKey]' is used as a passkey for legacy key derivation. This appears to be a debugging artifact or incorrect implementation. The legacy AI key derivation should use an actual key value, not the string representation of an object.

Copilot · 2025-10-29T09:25:43Z

app/Services/Storage/Value/StorageFileInfo.php

+        if ($name === 'mimeType') {
+            // @todo once PHP 8.4 is the baseline we can use the property hooks instead of the magic method
+            $extension = pathinfo($this->basename, PATHINFO_EXTENSION);
+            return [...($extension ? (new MimeTypes())->getMimeTypes($extension) : 'application/octet-stream')][0];


Incorrect array spread syntax: When extension is empty/false, the spread operator tries to spread a string 'application/octet-stream', which will result in an array of individual characters. Should be: return $extension ? ((new MimeTypes())->getMimeTypes($extension)[0] ?? 'application/octet-stream') : 'application/octet-stream';

Copilot · 2025-10-29T09:25:44Z

public/js/encryption.js

+ * @param {string} privateKey
+ * @return {Promise<string>} The decrypted data
+ */
+async function decryptWithHybrid(ciphertext, privateKey) {


Unused function decryptWithHybrid.

Copilot · 2025-10-29T09:25:45Z

public/js/encryption.js

-
 //#region Keychain Access

+async function keychainSet(key, value, type = 'room_key') {


Unused function keychainSet.

Copilot · 2025-10-29T09:25:45Z

public/js/encryption.js


-// Set the keychain value in IndexedDB
-async function keychainSet(key, value, formatToJWK, backup = true) {
+async function keychainGet(key, keyType = 'room_key') {


Unused function keychainGet.

Copilot · 2025-10-29T09:25:45Z

public/js/encryption.js


-async function setPassKey(enteredKey){
-    if(enteredKey === ''){
+async function setPassKey(enteredKey) {


Unused function setPassKey.

Copilot · 2025-10-29T09:25:45Z

public/js/encryption.js

+        throw new Error('Invalid hybrid ciphertext format');
+    }

+    const passphrase = await decryptWithPrivateKey(ciphertext.passphrase, privateKey, true);


Superfluous argument passed to function decryptWithPrivateKey.

# Conflicts: # .env.example # _documentation/5-Deployment/5-Authentication.md # app/Services/Auth/ChainedAuthService.php # app/Utils/DecoratorTrait.php # config/hawki_version.json # public/js/encryption.js # resources/views/layouts/home.blade.php

Ariansdf and others added 30 commits May 23, 2025 14:48

external api endpoints added

763e137

inv Routes

53bf69e

feat: implement external app backend

9674a36

Merge branch 'refs/heads/development' into feature/external-chat

c96a336

fix: ensure the system runs without registered announcements

e9db8a8

refactor: add compatibility with changed code

c107be9

fix: refactor strange singleton registration

db0f6f5

fix: fix frontend issues

7c72f64

fix: add missing composer dependencies

54ab0f3

fix: ensure thread id in group message handler

09be80b

refactor: clean up ai services

ae539aa

fix: adjust ConnectionFactory for new ai service

3a6f205

fix: fix various issues after merging

9f25ff5

Merge branch 'refs/heads/development' into feature/external-chat

63036fe

fix: fix broken rollbacks on migrations

829ff48

feat: further implementation

824e8f5

feat: finalize ext app implementation

46032f0

fix: fix exception in ExtAppListCommand.php

0effe74

fix: implement better solution for dev command

4686281

build: ensure file uploads up to 100MB (from PHP side)

e717960

Initial plan

dc481d7

Initial plan for cropperjs v2 migration

04dedc6

Co-authored-by: Neunerlei <[email protected]>

Update cropperjs to v2 with migration changes

97fff2e

Co-authored-by: Neunerlei <[email protected]>

Fix promise chain error handling in saveCroppedImage

026b002

Co-authored-by: Neunerlei <[email protected]>

Merge branch 'fix/Martin/bump-versions' into copilot/update-cropperjs…

e1bc39b

…-to-v2 # Conflicts: # package-lock.json # package.json

refactor: finish implementation of cropper v2

8ca4cbc

Ariansdf and others added 22 commits October 28, 2025 08:55

Merge pull request #215 from hawk-digital-environments/fix/Martin/php…

a2d744d

…-upload-size build: ensure file uploads up to 100MB (from PHP side)

Merge pull request #218 from hawk-digital-environments/copilot/update…

77ebc6e

…-cropperjs-to-v2 Migrate cropperjs from v1.6.2 to v2.1.0

fix(LDAP): add missing braces to closure

0355403

Merge pull request #222 from hawk-digital-environments/fix/Martin/lda…

9388572

…p-add-missing-braces fix(LDAP): add missing braces to closure

fix: Ensure REVERB_APP_KEY defaults to "hawki2"

1c80160

(cherry picked from commit e6bd8cf)

fix: do not fail if stream property is missing

4b8f5f9

(cherry picked from commit 436ebad)

fix: fix cascading error when postData in stream_functions.js fails

f9c5fb6

(cherry picked from commit 9a97fdf)

fix(Reverb): add missing braces to reverb config

9b8c65e

build: add dev hawki network

1bd8a37

docs: add potential alternatives for LDAP_ATTR_EMPLOYEETYPE

d9a230f

fix(LDAP): fix various minor issues and make errors in auth services …

97bc7dd

…easier to debug

fix: ensure artisan app:token command gets correct service

15fd992

feat: impelement automatic cache buster generation

8f520f4

refactor: adhere to copilot recommendations

4f58fde

Update config/app.php

2a35588

Co-authored-by: Copilot <[email protected]>

Rename APP_CACHE_BUST to APP_CACHE_BUSTER

da72cab

refactor: handle edge cases in DecoratorTrait

f7ce747

Merge remote-tracking branch 'origin/feat/Martin/implement-automatic-…

dc08a26

…cachebuster' into feat/Martin/implement-automatic-cachebuster

Merge pull request #223 from hawk-digital-environments/fix/Martin/var…

343c633

…ious-fixes-2.2.1 Fix/martin/various fixes 2.2.1

Merge pull request #224 from hawk-digital-environments/feat/Martin/im…

4054c59

…plement-automatic-cachebuster feat: impelement automatic cache buster generation

fix: fix various issues after merging development

3564c40

Neunerlei requested a review from Copilot October 29, 2025 09:22

Copilot AI reviewed Oct 29, 2025

View reviewed changes

Neunerlei force-pushed the development branch from 4fa4b89 to 3b6f16f Compare October 29, 2025 22:40

Neunerlei added 3 commits November 10, 2025 08:46

chore: sync container names and network names

5dba6fc

fix: fix type error in AiModelHandler.php

230a88e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/external chat #228

Feature/external chat #228

Uh oh!

Neunerlei commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Copilot AI Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		//#region Keychain Access

		async function keychainSet(key, value, type = 'room_key') {

Feature/external chat #228

Are you sure you want to change the base?

Feature/external chat #228

Uh oh!

Conversation

Neunerlei commented Oct 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants