Merged
Conversation
…te-caching fix: ensure routes have unique names
* feat(Auth): supercharge LDAP error logging * chore: adhere to copilot code review suggestions * docs: clarify usage of equals in LDAP Filter args
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors LDAP authentication configuration and implementation with a focus on improved validation, error handling, and code organization. Key changes include extracting LDAP-related logic into dedicated value objects, removing hardcoded default values, and fixing route naming inconsistencies.
- Refactored LDAP configuration into dedicated value objects (LdapConnectUri, LdapBindCredentials, LdapFilterArgs, LdapAttributeReader) with comprehensive validation
- Removed default port value (389) from LDAP configuration to support automatic port detection
- Updated route names to differentiate between GET and POST login endpoints
- Simplified error logging in ChainedAuthService by removing verbose exception chain details
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| routes/web.php | Updated route names to distinguish GET and POST login routes |
| config/ldap.php | Removed default port value and fixed employeeType attribute key casing |
| app/Services/Auth/Value/Ldap/LdapFilterArgs.php | New value object for LDAP filter arguments with validation |
| app/Services/Auth/Value/Ldap/LdapConnectUri.php | New value object for LDAP connection URI with automatic port detection |
| app/Services/Auth/Value/Ldap/LdapBindCredentials.php | New value object for LDAP bind credentials with password redaction |
| app/Services/Auth/Value/Ldap/LdapAttributeReader.php | New value object for reading LDAP attributes with display name builder integration |
| app/Services/Auth/Util/LdapUtil.php | New utility class for LDAP DN validation and filter value escaping |
| app/Services/Auth/ShibbolethService.php | Updated route reference to use new GET route name |
| app/Services/Auth/LdapService.php | Refactored to use new LDAP value objects with improved error handling |
| app/Services/Auth/Exception/LdapException.php | New exception class for LDAP-specific errors |
| app/Services/Auth/ChainedAuthService.php | Simplified error handling by removing verbose exception chains |
| app/Http/Controllers/AuthenticationController.php | Removed redundant error logging |
| _documentation/5-Deployment/5-Authentication.md | Updated LDAP configuration documentation |
| _changelog/README.md | Formatting improvements and additional release workflow details |
| .github/workflows/publish-version.yml | Removed unused footer title parameter |
| .github/.hawki-release/send-discord-notification.js | Simplified embed message building by removing footer title logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.