HAWNG-395: Handle warnings and false-positives #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 17, 2024
* .gitleaks.toml
* Provides an extension config which lists the false-positives that
should be ignored
* generate-.*\.sh
* Fixes shellcheck warnings is assignments
* nginx.sh
* Removes pipefail setting as non-POSIX and since pipes not actually used
in script then removed entirely
* Replaces bash (-v) which POSIX compatible equivalent
* ws-handler.ts
* Checks the origin of the MessageEvent. Since the messages are expected
from the cluster they should only comes from ${APP_HOST}/master so any
other origin is not appropriate so should be ignored
* .snyk
* Exclude non-production files from snyk analysis
phantomjinx
force-pushed
the
coverity-scan
branch
from
86d0f35 to
8f48e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitleaks.toml
Provides an extension config which lists the false-positives that should be ignored
generate-.*.sh
Fixes shellcheck warnings is assignments
nginx.sh
Removes pipefail setting as non-POSIX and since pipes not actually used in script then removed entirely
Replaces bash (-v) which POSIX compatible equivalent
ws-handler.ts
Checks the origin of the MessageEvent. Since the messages are expected from the cluster they should only comes from ${APP_HOST}/master so any other origin is not appropriate so should be ignored
.snyk
Exclude non-production files from snyk analysis