Skip to content

[REVERT][ruby] Stop Managing Signature Files#34

Merged
hayat01sh1da merged 2 commits intomasterfrom
hayat01sh1da/revert/ruby/stop-managing-signature-files
Apr 25, 2026
Merged

[REVERT][ruby] Stop Managing Signature Files#34
hayat01sh1da merged 2 commits intomasterfrom
hayat01sh1da/revert/ruby/stop-managing-signature-files

Conversation

@hayat01sh1da
Copy link
Copy Markdown
Owner

@hayat01sh1da hayat01sh1da commented Apr 25, 2026

1. Target PR to Revert

2. Context

Acccording to the article shown below, signrature files should be hosted and ought not to be generated in GitHub Actions workflow because they should be static on a repository.
That is why, bundle exec rbs-inline --output sig/generated/ . has been aborted since it generates new signature files and can make differences.

3. Reference

@hayat01sh1da hayat01sh1da self-assigned this Apr 25, 2026
@hayat01sh1da hayat01sh1da force-pushed the hayat01sh1da/revert/ruby/stop-managing-signature-files branch from f18656e to 844a6df Compare April 25, 2026 04:34
@hayat01sh1da hayat01sh1da reopened this Apr 25, 2026
@hayat01sh1da hayat01sh1da force-pushed the hayat01sh1da/revert/ruby/stop-managing-signature-files branch from 7a0234b to b2e130d Compare April 25, 2026 04:50
@hayat01sh1da hayat01sh1da force-pushed the hayat01sh1da/revert/ruby/stop-managing-signature-files branch from b2e130d to 844a6df Compare April 25, 2026 04:54
@hayat01sh1da hayat01sh1da reopened this Apr 25, 2026
@hayat01sh1da hayat01sh1da force-pushed the hayat01sh1da/revert/ruby/stop-managing-signature-files branch from 5cd9c59 to 844a6df Compare April 25, 2026 05:21
…op-managing-signature-files"

This reverts commit 844a6df, reversing
changes made to d1128e8.
@hayat01sh1da hayat01sh1da reopened this Apr 25, 2026
Copy link
Copy Markdown
Owner Author

@hayat01sh1da hayat01sh1da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayat01sh1da hayat01sh1da merged commit 890ff9d into master Apr 25, 2026
8 checks passed
@hayat01sh1da hayat01sh1da deleted the hayat01sh1da/revert/ruby/stop-managing-signature-files branch April 25, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant