Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spike] add scaffold for new validation plugin #1373

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[spike] add scaffold for new validation plugin #1373

wants to merge 2 commits into from

Conversation

hayes
Copy link
Owner

@hayes hayes commented Jan 7, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d9efa76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pothos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2025 1:16am

hayes
hayes commented Jan 7, 2025
View reviewed changes
packages/core/package.json
@@ -47,7 +47,7 @@
"provenance": true
},
"peerDependencies": {
"graphql": ">=16.6.0"
"graphql": "^16.8.1"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an annoying artifact of how pnpm upgrade -irL works with peer dependencies, and needs to be reverted

hayes
hayes commented Jan 7, 2025
View reviewed changes
packages/core/src/index.ts
) => PothosSchemaTypes.InputFieldRef<Types, T>;

export type ArgumentRef<Types extends SchemaTypes, T> = PothosSchemaTypes.ArgumentRef<Types, T>;
export const ArgumentRef = InternalArgumentRef as new <Types extends SchemaTypes, T>(
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes it so these types of Refs can be more easily extended by plugins

@hayes-mysten hayes-mysten mentioned this pull request Jan 30, 2025
Open
@hayes hayes added this to the Upcoming Pothos work milestone Feb 6, 2025
@hayes hayes force-pushed the mh--new-validation-plugin branch from 7582efa to d9efa76 Compare March 8, 2025 01:13
@hayes
Copy link
Owner Author

hayes commented Mar 8, 2025

Just pushed up an implementation of the main validation logic. I think this plugin is now mostly functional, but needs testing, docs, and some config for error handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Upcoming Pothos work
Development

Successfully merging this pull request may close these issues.
1 participant
@hayes