fix(prometheus-metrics): Fix metric type of DNS request latency

charts/kubebridge/Chart.yaml

@@ -24,13 +24,13 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.0
+version: 0.2.1
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "v0.2.0"
+appVersion: "v0.2.1"
 
 dependencies:
   - name: redis

charts/kubebridge/README.md

@@ -12,7 +12,7 @@ This document provides a reference for the configurable values in the `values.ya
 | `global.fullnameOverride`     | string | `""`                | Fully override common.names.fullname template.                                     |
 | `global.commonPodAnnotations` | object | See `values.yaml`   | Add annotations to pods of Sync and DNS components                                 |
 | `global.image.repository`     | string | `hayk96/kubebridge` | The Docker image repository.                                                       |
-| `global.image.tag`            | string | `v0.2.0`            | The Docker image tag.                                                              |
+| `global.image.tag`            | string | `v0.2.1`            | The Docker image tag.                                                              |
 
 ### Sync parameters
 

charts/kubebridge/values.yaml

@@ -12,7 +12,7 @@ global:
   image:
     repository: hayk96/kubebridge
     # Overrides the image tag whose default is the chart appVersion.
-    tag: "v0.2.0"
+    tag: "v0.2.1"
 
 sync:
   replicaCount: 1

src/dns/dns_server.py

@@ -119,17 +119,11 @@ def serve(self):
                         "lookup_time_ms": (exec_time * 1000).__round__(3)
                     })
 
-                    metrics.kubebridge_dns_requests.labels(
-                        app_name="dns",
-                        record_type=dns.QTYPE[request.q.qtype],
-                        record_name=request.q.qname,
-                        record_ip=reply.short()).inc()
-
                     metrics.kubebridge_dns_lookup_time_seconds.labels(
                         app_name="dns",
                         record_type=dns.QTYPE[request.q.qtype],
                         record_name=request.q.qname,
-                        record_ip=reply.short()).set(exec_time)
+                        record_ip=reply.short()).observe(exec_time)
 
         except KeyboardInterrupt:
             logger.error("Server shutting down...")

src/utils/metrics.py

@@ -1,4 +1,4 @@
-from prometheus_client import Gauge, Counter, disable_created_metrics
+from prometheus_client import Gauge, Summary, disable_created_metrics
 
 disable_created_metrics()
 
@@ -10,10 +10,6 @@
                                        "Number of services synchronized by the KubeBridge Sync component",
                                        labelnames=["app_name"])
 
-kubebridge_dns_requests = Counter("kubebridge_dns_requests",
-                                  "Total count of DNS requests processed for domain records",
-                                  labelnames=["app_name", "record_type", "record_name", "record_ip"])
-
-kubebridge_dns_lookup_time_seconds = Gauge("kubebridge_dns_lookup_time_seconds",
-                                           "Time taken to resolve DNS queries in seconds",
-                                           labelnames=["app_name", "record_type", "record_name", "record_ip"])
+kubebridge_dns_lookup_time_seconds = Summary("kubebridge_dns_lookup_time_seconds",
+                                             "Time taken to resolve DNS queries in seconds",
+                                             labelnames=["app_name", "record_type", "record_name", "record_ip"])