Skip to content

Add autoStepDownWhenLeader to MemberInfo [CORE-216] #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add autoStepDownWhenLeader to MemberInfo [CORE-216] #545

wants to merge 4 commits into from

Conversation

gareth-johnston
Copy link
Contributor

Adds autoStepDownWhenLeader boolean added to MemberInfo

@gareth-johnston gareth-johnston requested a review from Copilot April 11, 2025 07:19
Copilot

This comment was marked as spam.

Sign in to view

ihsandemir
ihsandemir requested changes Apr 17, 2025
View reviewed changes
protocol-definitions/custom/Custom.yaml Outdated
@@ -828,6 +828,10 @@ customTypes:
type: Map_EndpointQualifier_Address
nullable: false
since: 2.0.1
- name: autoStepDownWhenLeader
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: autoStepDownWhenLeader
- name: cpAutoStepDownWhenLeader

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that prefixing with cp makes it more understandable, especially for the future readers.

@gareth-johnston gareth-johnston force-pushed the CORE-216/abdicating-leadership branch from daccd74 to 83d5aaa Compare April 28, 2025 16:12
JamesHazelcast
JamesHazelcast approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@JamesHazelcast JamesHazelcast left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ihsandemir that prefixing with cp makes sense, to provide extra clarity - approving in advance though 👍

@gareth-johnston
Copy link
Contributor Author

I agree with @ihsandemir that prefixing with cp makes sense, to provide extra clarity - approving in advance though 👍

Do you think that is still relevant now? That comment was relating to when we were changing memberInfo - absolutely in that case. But now we are only changing CPMember -- I believe it is clear enough in this case, do you feel strongly?

@JamesHazelcast
Copy link
Contributor

Do you think that is still relevant now? That comment was relating to when we were changing memberInfo - absolutely in that case. But now we are only changing CPMember -- I believe it is clear enough in this case, do you feel strongly?

Ah, apologies - no I don't think it's relevant in that case, all good to go from my POV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ahmetmircik ahmetmircik ahmetmircik approved these changes

@JamesHazelcast JamesHazelcast JamesHazelcast approved these changes

@ihsandemir ihsandemir Awaiting requested review from ihsandemir

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gareth-johnston @JamesHazelcast @ahmetmircik @ihsandemir