MC-3230: Fix prometheus mapping names, wrap metrics tables to collapsible elements #484
Conversation
✅ Deploy Preview for frosty-curran-1fc0c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Rob Swain <[email protected]>
|
@Rob-Hazelcast thanks for the vigilant review and the suggested changes!! It should require backporting to 5.7 but neither I haven't yet merged the backport to the appropriate management-center branch nor there's an exact plan on when to release it. Hence, I'm not sure how to perform the backporting in the docs. Should I create a separate PR to 5.7 and merge it upon the 5.7.2 release? |
No problem. We don't have a set process - typically, new work goes into a new release branch cut from main on release day and isn't back-ported to existing branches. You could merge this to main now and create another PR to cherry pick it to 5.7 when 5.7.2 is released. Or you could add a "backport to 5.7" label to this PR and merge it (and the backport PR it'll create) on the day of the release. Maybe set this to draft so it doesn't get merged accidentally in the meantime. |
|
@Rob-Hazelcast sounds good, I'll add the label then, thanks for suggesting the proper way! |
|
@Rob-Hazelcast I wonder whether I can merge this one now? I'm planning to add more metric mappings (which won't be backported to 5.7.2) and I thought of doing separates PRs for them, as long as I'll be probably adding them in batches. |
You could merge this PR (to main) now. The backport label will create another PR against the 5.7 branch. We should not merge that PR until 5.7.2 is released - we should never publish documentation for features/changes that are not yet available. |
|
Yeah, that's what I thought, regarding pr to 5.7. Once it's there - I'll turn it to draft and will mention you in the PR itself. So, would you mind approving this one so far? :) |
Sorry, forgot I hadn't approved already! |
No description provided.