Exercise Mode Editing Capabilities #1444
Conversation
…te while in instructor mode
…ser is editing title, also automated swapping between focus on title-box/editors
…es, this also solves issue of text-box with incorrect value persisting across exercise slides when switching while editing
…hen switching between exercise slides; added confirm and cancel edit buttons for finalizing title updates (or cancelling them), this also fixes a bug with pressing enter to confirm where it would also press enter in the respective code editor where the cursor was located
… are non-functional still)
…to-do: allow editing of implementation hints as they default to "no hint available"
…to-do: allow editing of implementation hints as they default to "no hint available
…s to be set off read-only
… : string, version : int) pairs; edited title now saves on refresh
… and load added/deleted mutants
… and load added/deleted mutants
… and load added/deleted mutants
cyrus-
left a comment
cyrus-
left a comment
There was a problem hiding this comment.
- Instructor Mode should be off by default when you load an exercise, since it now includes a bunch of things we don't want new users to have to think about.
- Prompt should not be bolded by default.
- Cut/copy/paste does not work in exercise mode editors.
- Not sure how hard this is, but unicode symbols are mangled when included in the prompt, e.g. I wanted to use unicode triple equals ≡ but it does not work.
- Is it possible for the hints to be a field under each mutant, rather than separately in the Mutation Testing box?
- Syntax Validation box should include a way to edit the % discount on points.
- Instead of "New point max" just say "Points"
- Too much space between exercise title, module name and prompt.
|
|
Unicode seems to be working on prompt locally in this format ≡ edit: meant that unicode works when inputing the following "≡" |
|
@facundoy regarding Unicode, this is what happens when I enter It turns into an a in this case: When I edit it again I get an unknown character: |
|
A few bugs:
Still need to implement:
|
|
@russell-rozenbaum @facundoy there are a few conflicts to resolve here. could we get this PR fixed up and ready to merge this week? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1444 +/- ##
==========================================
+ Coverage 50.02% 50.11% +0.09%
==========================================
Files 130 134 +4
Lines 14456 14855 +399
==========================================
+ Hits 7231 7444 +213
- Misses 7225 7411 +186
🚀 New features to boost your workflow:
|
|
@facundoy There is a bug where the page freezes whenever I try to confirm edits in the prompt. Does this happen for you as well? Any idea what this could be? |
…(since editing an input-box) leads to infinite page load
|
@russell-rozenbaum is your last commit solving this bug? I tested it locally with that change and the prompt editing seems to be working without issue, and it was working fine when I solved the merge conflicts this weekend if I remember correctly.
|
@facundoy No, my most recent commit only fixed a bug with reloading a page while editing. This seems to be a different issue. Whenever I make an edit in the prompt edit box specifically, the page becomes unresponsive. I don't think this is only on my machine, as it happens on both my local server and the branch's server. |
|
@russell-rozenbaum or @facundoy Russell let me know that this never actually got merged. there is a conflict in 1 file right now, can one of you resolve that and we can get this merged? |
TL;DR
Exercise Mode is fully (mostly) editable
Added Features
Adds ability to edit all* Exercise Mode features:
*Still need to add editing for Syntax Tests
Also adds BlankExercise.ml for a completely blank exercise spec. Might be useful when creating new exercise button... just make sure to change UUID.
Not Bugs, but Relatively Important Things for Editing an Exercise