Skip to content

Final tutorial sys #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Final tutorial sys #1468

wants to merge 10 commits into from

Conversation

reevafaisal
Copy link

No description provided.

@reevafaisal reevafaisal marked this pull request as draft January 20, 2025 13:13
@facundoy
Copy link
Contributor

facundoy commented Jan 25, 2025

Known bug: evaluation of the YourImplementation editor is incorrect.
I think that there may some issues with the stitching but not 100% sure.
Tutorial edits not being saved + unable to highlight multiple lines on editor

NOTES:

  • Need to specify tutorial module names when stitching in order to set wrapper to true or false since we will only need the wrapper for specific exercises

@reevafaisal
Copy link
Author

So in my last commit when I said local, I meant global.

BUG:
Also I noticed there is a bug in the boolean exercise. Appears that whenever you type, based on the movements of the cursor the table appears to dissapear and reappear. Since we just added the new exercises in, we need to make sure it works with the widget.

@reevafaisal reevafaisal marked this pull request as ready for review March 31, 2025 12:18
@reevafaisal reevafaisal marked this pull request as draft March 31, 2025 12:18
@reevafaisal reevafaisal marked this pull request as ready for review March 31, 2025 12:20
@reevafaisal reevafaisal marked this pull request as draft March 31, 2025 12:20
@reevafaisal reevafaisal closed this Apr 1, 2025
@reevafaisal reevafaisal reopened this Apr 1, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.30%. Comparing base (39a4043) to head (7b3afea).

Files with missing lines Patch % Lines
src/haz3lcore/lang/term/TermBase.re 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1468      +/-   ##
==========================================
+ Coverage   46.28%   46.30%   +0.02%     
==========================================
  Files         126      126              
  Lines       13991    13993       +2     
==========================================
+ Hits         6476     6480       +4     
+ Misses       7515     7513       -2     
Files with missing lines Coverage Δ
src/haz3lcore/statics/Elaborator.re 74.80% <ø> (+0.06%) ⬆️
src/haz3lcore/lang/term/TermBase.re 54.38% <0.00%> (-0.11%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@reevafaisal
Copy link
Author

Based on the print statements, it seems like there is a constant recursion over label in the normalize function. Im not sure where exactly the bug lies but it seems like it is not able to detect that the expression is incomplete.

@cyrus- cyrus- marked this pull request as ready for review April 21, 2025 22:05
@cyrus-
Copy link
Member

cyrus- commented Apr 21, 2025

  • previous button on all slides
  • get rid of checkmark animation, make it smaller and think about styling of the three buttons at the bottom (same size maybe?)
  • fix crash on clicking previous button or next button when that goes out of bounds
  • newlines in slide text
  • make the hint an option rather than required
  • hover message over the info button

@cyrus-
Copy link
Member

cyrus- commented Apr 21, 2025

  • instructions for creating new tutorials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants