Skip to content

Proof Steps #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 29 commits into
base: dev
Choose a base branch
from
Draft

Proof Steps #1533

wants to merge 29 commits into from

Conversation

Negabinary
Copy link
Contributor

@Negabinary Negabinary commented Feb 21, 2025

Overview

This branch adds new kinds of steps to the stepper

In particular it adds steps for:

  • Cases (e.g. case on whether a boolean is true/false)
  • Axioms (e.g. x * 0 = 0)
  • Rewrites (write your own axiom and check it with a SAT solver)

We are also porting over the coq export from #1193 for basic axiom steps.

TODOS:

  • Skel-based selection
  • Fix hidden steps
  • substitute variables in axioms
  • fix closure issues
  • add context to proofs
  • Coq export for axioms
  • Make selection select subtrees
  • add inductive hypotheses to cases
  • add an error message if cases don't end at the same value
  • inexhaustive error message
  • Fix duplicated ids in substitution
  • Add conditions to axioms
  • Add back the styling for hidden steps
  • Prevent variable escape at the end of forall (last_step in forall)
  • Require filling out under-specified rewrites
  • Make the exp substitution more principled
  • Fix capture in substitution
  • Fix capture in evaluation etc
  • Put rewrites in a box
  • Make evaluate work

After this pr:

  • Add a Theorem keyword and put the proofs in splices
  • Make the patterns in case actually patterns and run exhaustivity, redundancy, ...
  • Pattern unpacking

@Negabinary Negabinary changed the title Add some proof steps Add proof steps Feb 24, 2025
@Negabinary Negabinary changed the title Add proof steps Proof Steps Feb 24, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 19.10112% with 72 lines in your changes missing coverage. Please review.

Project coverage is 48.34%. Comparing base (9a8d9d9) to head (9c1ec36).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
src/haz3lcore/dynamics/Substitution.re 0.00% 50 Missing ⚠️
src/util/ListUtil.re 0.00% 10 Missing ⚠️
src/haz3lcore/dynamics/Transition.re 72.72% 6 Missing ⚠️
src/haz3lcore/dynamics/DHExp.re 0.00% 3 Missing ⚠️
src/haz3lcore/dynamics/ValueChecker.re 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1533      +/-   ##
==========================================
- Coverage   48.95%   48.34%   -0.61%     
==========================================
  Files         109      110       +1     
  Lines       11996    12139     +143     
==========================================
- Hits         5873     5869       -4     
- Misses       6123     6270     +147     
Files with missing lines Coverage Δ
src/haz3lcore/dynamics/Evaluator.re 75.00% <100.00%> (ø)
src/haz3lcore/lang/term/Term.re 52.03% <ø> (ø)
src/util/Web.re 1.47% <ø> (ø)
src/haz3lcore/dynamics/DHExp.re 31.70% <0.00%> (-1.21%) ⬇️
src/haz3lcore/dynamics/ValueChecker.re 0.00% <0.00%> (ø)
src/haz3lcore/dynamics/Transition.re 38.25% <72.72%> (-0.02%) ⬇️
src/util/ListUtil.re 32.49% <0.00%> (-1.06%) ⬇️
src/haz3lcore/dynamics/Substitution.re 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Negabinary Negabinary marked this pull request as draft April 4, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants