-
Notifications
You must be signed in to change notification settings - Fork 58
Proof Steps #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Proof Steps #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1533 +/- ##
==========================================
- Coverage 50.09% 49.99% -0.10%
==========================================
Files 134 134
Lines 14855 14872 +17
==========================================
- Hits 7441 7435 -6
- Misses 7414 7437 +23
🚀 New features to boost your workflow:
|
cyrus-
reviewed
Jun 11, 2025
cyrus-
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This branch adds new kinds of steps to the stepper
In particular it adds steps for:
x * 0 = 0
)We are also porting over the coq export from #1193 for basic axiom steps.
TODOS:
TODOs for this pr:
After this pr:
inexhaustive error message
add an error message if cases don't end at the same value
Coq export for axioms
Make selection select subtrees
add inductive hypotheses to cases
Fix capture in substitution
Fix capture in evaluation etc
Add conditions to axioms
Make evaluate work
Require filling out under-specified rewrites
Make the exp substitution more principled
Cleanup: combine Match Exp and Filter match
Add a Theorem keyword and put the proofs in splices
Make the patterns in case actually patterns and run exhaustivity, redundancy, ...
Pattern unpacking