Put projectors into web then quickly pull it out #1620
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents a trial attempt to move all of core (after semantics was extracted) into web, and then pull projectors out (wanted to get an idea if a functorial approach might work well here). I created a module type representing projectors current syntax dependency, to use as a kind of stand-in for a future Editor.t dependency:
(these are all things projectors currently use, somewhat incidentally)
Then i turned ProjectorBase.Projector into a functor taking that as an argument:
and the implementations get functorized as well:
BUT with the above i can't figure out how to reinstate the GADT type constraints we previouslu introduced here e.g.
with model = ProjectorCore.Kind.fold_model
I got as far as trying to functorize the to_module functionality:
but now I start running into, I think, that effect of removing that type constraint: