Skip to content

Small big step confluence test #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged

Small big step confluence test #1633

merged 5 commits into from
May 20, 2025

Conversation

7h3kk1d
Copy link
Contributor

@7h3kk1d 7h3kk1d commented Apr 25, 2025

Adds a qcheck test that says if the small steps from the stepper evaluate to a value that should be equivalent to the evaluator. Always chooses the first available step.

It's currently real slow and doesn't find issues every time. I'm also not calling EvaluatorStep.refresh_step which might be important.

Example failure (Fixed in #1657):

FAIL Small step reduction and big step reduction are equal

   Expected: `fun x: (?) -> fun (()): (()) -> x'
   Received: `fun x: (?) -> fun (()): (()) -> x''

`
on `fun x -> fun (()) -> x (after 2 shrink steps)`

- Test is quite slow
- Also added a couple stepper tests
@7h3kk1d 7h3kk1d changed the base branch from dev to cat-resiliency April 25, 2025 14:36
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.41%. Comparing base (9dc2479) to head (7ac321a).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1633      +/-   ##
==========================================
+ Coverage   50.08%   50.41%   +0.32%     
==========================================
  Files         130      134       +4     
  Lines       14462    15036     +574     
==========================================
+ Hits         7244     7580     +336     
- Misses       7218     7456     +238     
Files with missing lines Coverage Δ
src/haz3lcore/dynamics/Evaluator.re 92.98% <ø> (-3.32%) ⬇️
src/haz3lcore/dynamics/stepper/EvaluatorStep.re 60.43% <ø> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from cat-resiliency to dev April 29, 2025 15:55
@7h3kk1d 7h3kk1d changed the base branch from dev to recursive-stepper May 19, 2025 21:03
@7h3kk1d 7h3kk1d marked this pull request as ready for review May 20, 2025 14:05
@7h3kk1d 7h3kk1d requested a review from cyrus- May 20, 2025 14:06
Base automatically changed from recursive-stepper to dev May 20, 2025 14:52
@cyrus- cyrus- merged commit 89e6656 into dev May 20, 2025
4 checks passed
@cyrus- cyrus- deleted the small-big-step-confluence branch May 20, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants