-
Notifications
You must be signed in to change notification settings - Fork 62
Exolivelits #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
disconcision
wants to merge
86
commits into
dev
Choose a base branch
from
exolivelits
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Exolivelits #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pointermove and pointerup event listeners were being registered at module load time, which fails in Node.js test environment since document is undefined. Changed to lazy initialization pattern: - Listeners are only attached when resize is first initiated - setup_resize_listeners() is called from resize_pointerdown() - Uses a ref flag to ensure listeners are only attached once This fixes the "Cannot read properties of undefined (reading 'addEventListener')" error when running tests. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Instead of manually checking Fold + first matching livelit, iterate over ProjectorCore.Kind.projectors to show all applicable projectors in menu. Co-Authored-By: Claude Opus 4.5 <[email protected]>
25 tasks
Merge dev branch into exolivelits, resolving conflicts in ExpToSegment.Settings.t type definition. Renamed Inline.t variants to be more descriptive: - Single -> Inline (no newlines, everything on one line) - Compound -> Block (newlines for block structures) - Zzt -> ExpandElements (also newlines in tuples/lists) Added documentation comments explaining each variant's behavior and use cases. Co-Authored-By: Claude Opus 4.5 <[email protected]>
The inline setting changed from bool to Inline.t algebraic data type. Updated Theorem case to match other block structures. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.