Skip to content

Conversation

@disconcision
Copy link
Member

@disconcision disconcision commented Aug 29, 2025

  • Don't re-register every view. on first view, save entry to registry ref, update only on update

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 13.80789% with 1005 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.54%. Comparing base (b90744a) to head (a6d03fa).

Files with missing lines Patch % Lines
...e/projectors/implementations/ObservablePlotProj.re 0.00% 332 Missing ⚠️
.../haz3lcore/projectors/implementations/GraphProj.re 0.00% 328 Missing ⚠️
src/haz3lcore/HazelProtocol.re 52.71% 113 Missing ⚠️
src/haz3lcore/ExternalProjectorBridge.re 0.00% 90 Missing ⚠️
src/haz3lcore/WebEnv.re 0.00% 33 Missing ⚠️
...rc/haz3lcore/projectors/implementations/ExoProj.re 0.00% 23 Missing ⚠️
src/haz3lcore/projectors/Exo.re 23.07% 20 Missing ⚠️
src/util/JsUtil.re 0.00% 19 Missing ⚠️
src/haz3lcore/pretty/ExpToSegment.re 52.63% 9 Missing ⚠️
src/language/ProjectorKind.re 64.70% 6 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1911      +/-   ##
==========================================
- Coverage   50.37%   48.54%   -1.84%     
==========================================
  Files         230      238       +8     
  Lines       25368    26501    +1133     
==========================================
+ Hits        12780    12865      +85     
- Misses      12588    13636    +1048     
Files with missing lines Coverage Δ
src/b2t2/Datasheet.re 100.00% <ø> (ø)
src/haz3lcore/derived/BuiltinsPrinter.re 5.55% <100.00%> (ø)
...z3lcore/projectors/implementations/CSVProjector.re 0.00% <ø> (ø)
...z3lcore/projectors/implementations/CheckboxProj.re 16.66% <ø> (ø)
...az3lcore/projectors/implementations/LivelitProj.re 0.00% <ø> (-4.77%) ⬇️
...az3lcore/projectors/implementations/SliderFProj.re 16.66% <ø> (ø)
...haz3lcore/projectors/implementations/SliderProj.re 16.66% <ø> (ø)
...z3lcore/projectors/implementations/TextAreaProj.re 7.57% <ø> (ø)
src/haz3lcore/zipper/action/Introduce.re 80.37% <ø> (ø)
src/haz3lcore/zipper/action/Triggers.re 80.48% <100.00%> (ø)
... and 31 more

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

disconcision and others added 19 commits November 7, 2025 19:48
The pointermove and pointerup event listeners were being registered
at module load time, which fails in Node.js test environment since
document is undefined.

Changed to lazy initialization pattern:
- Listeners are only attached when resize is first initiated
- setup_resize_listeners() is called from resize_pointerdown()
- Uses a ref flag to ensure listeners are only attached once

This fixes the "Cannot read properties of undefined (reading
'addEventListener')" error when running tests.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Instead of manually checking Fold + first matching livelit, iterate over
ProjectorCore.Kind.projectors to show all applicable projectors in menu.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@disconcision disconcision mentioned this pull request Jan 29, 2026
25 tasks
disconcision and others added 10 commits January 28, 2026 22:39
Merge dev branch into exolivelits, resolving conflicts in
ExpToSegment.Settings.t type definition.

Renamed Inline.t variants to be more descriptive:
- Single -> Inline (no newlines, everything on one line)
- Compound -> Block (newlines for block structures)
- Zzt -> ExpandElements (also newlines in tuples/lists)

Added documentation comments explaining each variant's behavior
and use cases.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
The inline setting changed from bool to Inline.t algebraic data type.
Updated Theorem case to match other block structures.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants