Skip to content

Conversation

@Cryplo
Copy link
Contributor

@Cryplo Cryplo commented Oct 13, 2025

No description provided.

Cryplo and others added 20 commits September 12, 2025 16:18
…line numbers stay appeared when horizontally scrolled far to the right
…re that line numbers still lineup like before
…splay absolute line number when in relative mode
@7h3kk1d
Copy link
Contributor

7h3kk1d commented Oct 13, 2025

@Cryplo it might be worth looking at the cards documentation slide as it has some multi-line projectors that I assume we want to offset with the line numbers.

Screencast.From.2025-10-13.14-17-52.webm

In the above screenrecording there is no line 15 so we probably want to shift it down.

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 9.25926% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.70%. Comparing base (eceb0ad) to head (334dbcb).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/web/app/editors/lines/LineNumbers.re 0.00% 36 Missing ⚠️
src/web/Settings.re 0.00% 7 Missing ⚠️
src/web/app/editors/code/CodeEditable.re 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1986      +/-   ##
==========================================
- Coverage   49.79%   49.70%   -0.09%     
==========================================
  Files         218      219       +1     
  Lines       23103    23154      +51     
==========================================
+ Hits        11504    11509       +5     
- Misses      11599    11645      +46     
Files with missing lines Coverage Δ
src/haz3lcore/derived/Measured.re 53.74% <100.00%> (+0.96%) ⬆️
src/haz3lcore/lang/Token.re 81.31% <ø> (ø)
src/haz3lcore/tiles/Secondary.re 66.66% <100.00%> (+3.80%) ⬆️
src/web/app/editors/code/CodeEditable.re 0.00% <0.00%> (ø)
src/web/Settings.re 0.00% <0.00%> (ø)
src/web/app/editors/lines/LineNumbers.re 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Cryplo
Copy link
Contributor Author

Cryplo commented Oct 13, 2025

@Cryplo it might be worth looking at the cards documentation slide as it has some multi-line projectors that I assume we want to offset with the line numbers.

Screencast.From.2025-10-13.14-17-52.webm

In the above screenrecording there is no line 15 so we probably want to shift it down.

Great point, I'll write some code to offset the line numbers for multiline projectors

@Cryplo
Copy link
Contributor Author

Cryplo commented Oct 20, 2025

@7h3kk1d For the most part, line skipping for multi-line projectors is working now. However, there's a small issue. If there's a multi-line tab projector on the last line, as pictured below, the line doesn't seem to skip. Would you happen to know why this might be?

Currently, the way my code works is by checking each row and seeing if any multiline projectors span across that row, then skipping that row. Specifically, my code checks if each row is greater than a measurement's origin row and less than a measurement's final row (which both means the projector is multi-line and the row is within this multi-line projector). I think that this error is because the last secondary measurement doesn't consume the line break that the Card projector should give it, so the secondary measurement is treated as if it doesn't have any projectors that cause deferred line breaks?

Screenshot 2025-10-19 at 11 17 48 PM

@Cryplo Cryplo requested a review from disconcision November 7, 2025 22:14
@cyrus- cyrus- marked this pull request as draft December 1, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants