Line numbers #1986
Line numbers #1986
Conversation
…line numbers stay appeared when horizontally scrolled far to the right
…re that line numbers still lineup like before
…splay absolute line number when in relative mode
…rrent line number styling
|
@Cryplo it might be worth looking at the cards documentation slide as it has some multi-line projectors that I assume we want to offset with the line numbers. Screencast.From.2025-10-13.14-17-52.webmIn the above screenrecording there is no line 15 so we probably want to shift it down. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #1986 +/- ##
==========================================
- Coverage 50.37% 50.22% -0.16%
==========================================
Files 230 231 +1
Lines 25365 25419 +54
==========================================
- Hits 12777 12766 -11
- Misses 12588 12653 +65
🚀 New features to boost your workflow:
|
Great point, I'll write some code to offset the line numbers for multiline projectors |
…ll finish in a bit
… value for each row is, improving effeciency
|
@7h3kk1d For the most part, line skipping for multi-line projectors is working now. However, there's a small issue. If there's a multi-line tab projector on the last line, as pictured below, the line doesn't seem to skip. Would you happen to know why this might be? Currently, the way my code works is by checking each row and seeing if any multiline projectors span across that row, then skipping that row. Specifically, my code checks if each row is greater than a measurement's origin row and less than a measurement's final row (which both means the projector is multi-line and the row is within this multi-line projector). I think that this error is because the last secondary measurement doesn't consume the line break that the Card projector should give it, so the secondary measurement is treated as if it doesn't have any projectors that cause deferred line breaks? 
|
…le to dinstinguish between truly skipped rows and linebreak rows
…tual linebreaks vs actual empty lines
disconcision
left a comment
disconcision
left a comment
There was a problem hiding this comment.
Looks solid; minor changes requested, then we're good to merge from my perspective. @cyrus- maybe do a quick functional review to make sure it satisfies your use case. Let's consider visually de-emphasizing line numbers a bit; below I use colors --BR1 and --BR2. that's plenty visible on my screen but if it seems too faint we could increment those numbers. I also changed the L/R passing to 0em/1em, which I think feels a bit less cramped while not actually taking up any more space
3 participants
No description provided.