Function that takes term transformations and lifts them to segment transformations #2001
+1,066
−764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g transformations - Introduce ~override parameter to exp_to_pretty and related functions in ExpToSegment.re to allow custom segment handling based on IDs - Add new LiftToSegment.re module with lift_segment function for transforming expressions while preserving segment structure - Update ErrorPrint.re to use any_to_segment for consistent segment-based printing - Refactor ProdProjection handling in ExpToSegment.re for improved override integration
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2001 +/- ##
==========================================
+ Coverage 51.44% 51.58% +0.13%
==========================================
Files 209 210 +1
Lines 21721 21744 +23
==========================================
+ Hits 11175 11217 +42
+ Misses 10546 10527 -19
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only handling leaf level preservation of segments and requires the id to be correctly maintained by the callsite (same id will result in same segment). We would like for non-leaf level formatting and incomplete syntax. I'm also not handling any extra parenthesization that needs to be inserted.