cleanup: remove closure environment from FixF terms #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated FixF constructor in MakeTerm.re to omit the third argument - Adjusted pattern matching and pretty printing in ExpToSegment.re - Simplified fixpoint evaluation logic in Evaluator.re by removing closure handling - Removed extraneous None arguments in builtin definitions This change simplifies the FixF representation by eliminating the optional closure environment, reducing complexity in term construction and evaluation.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #2015 +/- ##
==========================================
+ Coverage 49.79% 49.82% +0.03%
==========================================
Files 218 218
Lines 23109 23099 -10
==========================================
+ Hits 11506 11508 +2
+ Misses 11603 11591 -12
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the FixF representation by eliminating the optional closure environment, reducing complexity in term construction and evaluation.
@Negabinary I removed it and all the tests seem to pass. I haven't reasoned through anything so not sure why it was there.