-
Notifications
You must be signed in to change notification settings - Fork 61
Log Replay #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Log Replay #2026
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #2026 +/- ##
==========================================
- Coverage 50.38% 50.30% -0.08%
==========================================
Files 230 230
Lines 25365 25387 +22
==========================================
- Hits 12780 12772 -8
- Misses 12585 12615 +30
🚀 New features to boost your workflow:
|
5160845 to
adc4b95
Compare
Code reviewFound 1 issue during review: Inconsistent mode switch handling in Editors.reLocation: Issue: The case Context: hazel/src/web/app/editors/Editors.re Lines 173 to 189 in adc4b95
The code shows: | (SwitchMode(Scratch), Scratch(_))
| (SwitchMode(Documentation), Documentation(_))
| (SwitchMode(Exercises), Exercises(_)) => model |> return_quietBut for Tutorial on line 188: | (SwitchMode(Tutorial), Tutorial(_)) => model |> raise_invalid_actionProblem: Switching to Tutorial mode when already in Tutorial mode will raise an Suggested fix: Change line 188 to use | (SwitchMode(Tutorial), Tutorial(_)) => model |> return_quiet |
203ca88 to
47c799b
Compare
7e93e63 to
3f66008
Compare
cyrus-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- log replay should stop when it runs out of messages (I believe fixed during meeting)
- add export button back to the log panel
- fix indentation of the import & reset button
okay with merging once those are addressed
Adds a log replay feature to Hazel, when the setting is enabled, a log replay panel appears on the right of the screen