Fix #1974 #2004 #2033
Open
Fix #1974 #2004 #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import scratch accept txt files
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2033 +/- ##
==========================================
- Coverage 51.37% 51.21% -0.17%
==========================================
Files 212 212
Lines 21838 21841 +3
==========================================
- Hits 11220 11185 -35
- Misses 10618 10656 +38
🚀 New features to boost your workflow:
|
Contributor
Author
|
Noticed that Firefox doesn't add the .txt file extension by default when exporting. Not sure how to change that so I've removed the expectation that the imported scratch file has .txt extension. |
Contributor
Author
|
@cyrus- I can't repro the broken import. Could you try again and report back? |
Member
|
@dm0n3y It's still happening to me, though the first time I loaded the file it did seem to work but not any subsequent times? |
Reset file input value after import completes to allow the same file to be selected and imported multiple times. Without this, the browser's file input won't fire the change event when selecting the same file again. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
Author
|
@cyrus- fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scratch import button used to only take .json files, despite export button producing .txt files. Now scratch import takes .txt files. I considered exporting/importing .sexp but this isn't a standard MIME type and noticed that this broke file preview in my macOS finder and left it as .txt for now.
This PR also fixes a serialization/deserialization bug where scratch export would serialize all scratch slides while scratch import only deserialized a single slide. Now scratch export serializes only the current scratch slide.
Fixes #1947 and #2004