Probe fixes #2098
Merged
Probe fixes #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a sample has no environment bindings to display, the context menu actions (Pin/Step into) now stack vertically like a traditional menu instead of horizontally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
After the refactor that changed projector actions from IDs to indices, clicking on probe samples caused a List.nth failure. The issue was that refractor indices were computed from refractor_list in the view layer, but ProjectorPerform.go only received projector_list for index lookup. Added refractor_list parameter to ProjectorPerform.go and use is_refractor(kind) to select the correct list for Focus and SetModel actions. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Convert recursive do_until and do_until_piece functions in Zipper.re to iterative implementations using while loops. The previous recursive versions would overflow the JavaScript call stack when traversing documents with thousands of tokens. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #2098 +/- ##
==========================================
+ Coverage 50.47% 50.49% +0.02%
==========================================
Files 229 229
Lines 25189 25203 +14
==========================================
+ Hits 12713 12726 +13
- Misses 12476 12477 +1
🚀 New features to boost your workflow:
|
cyrus-
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four fixes.
1. Fix stack overflow on select-all for large programs
Convert recursive
do_untilanddo_until_piecefunctions inZipper.reto iterative implementations. Theprevious recursive versions would overflow the JavaScript call stack when traversing documents with thousands of
tokens (e.g., select-all on large files). Not totally sure why we didn't see this before; or at least I hadn't seen it before the last month or so.
2. Fix probe sample click failing with nth exception
After the refactor that changed projector actions from IDs to indices, clicking on probe samples caused a
List.nthfailure. Added
refractor_listparameter toProjectorPerform.goto correctly resolve indices for refractor(probe) actions. closes #2097.
3. Render sample context menu vertically when environment is empty
When a sample has no environment bindings to display, the context menu actions (Pin/Step into) now stack vertically
like a traditional menu instead of horizontally. Improves usability when there's no environment section.
4. Remove Claude Action
After doing the reading I think doing this in a repo where other people can use Claude is a TOS violation