Fix exercise module export serialization for refractors #2103
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2099 The exercise module export was using Zipper.show() which tried to serialize refractors.autos containing Id.Map.t(unit). The Id.Map.pp function output debug-style text that was not valid OCaml syntax, resulting in blank fields like `ids = ;` in the exported .ml file. Changes: - Add Refractors.for_serialization to reset non-persistable fields (autos, sample_cursor) before serialization, keeping only manuals - Update Id.Map.pp to output valid OCaml for empty maps, fail explicitly for non-empty maps with a helpful error message - Use for_serialization in Exercise.editor_pp before calling Zipper.show() This aligns with the existing design where only manuals is persisted (see state location docs in Refractors.re). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2103 +/- ##
==========================================
+ Coverage 50.37% 50.39% +0.01%
==========================================
Files 230 230
Lines 25368 25368
==========================================
+ Hits 12780 12783 +3
+ Misses 12588 12585 -3
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2099
The exercise module export was using Zipper.show() which tried to serialize refractors.autos containing Id.Map.t(unit). The Id.Map.pp function output debug-style text that was not valid OCaml syntax, resulting in blank fields like
ids = ;in the exported .ml file.Changes:
This aligns with the existing design where only manuals is persisted (see state location docs in Refractors.re).