-
Notifications
You must be signed in to change notification settings - Fork 61
Write out steps #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Negabinary
wants to merge
7
commits into
bring-back-ih
Choose a base branch
from
write-steps
base: bring-back-ih
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Write out steps #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## fix-infinite-lookup #2111 +/- ##
=======================================================
- Coverage 50.21% 49.87% -0.35%
=======================================================
Files 230 231 +1
Lines 25436 25628 +192
=======================================================
+ Hits 12772 12781 +9
- Misses 12664 12847 +183
🚀 New features to boost your workflow:
|
750377e to
ecd5539
Compare
3b831f9 to
f73087e
Compare
6f7002f to
dc18233
Compare
f73087e to
5f64709
Compare
dc18233 to
ee7350f
Compare
Member
|
reflexivity isn't working in the inductive case |
Member
|
also the proof doesn't seem to work with built in map |
5f64709 to
8f5d36a
Compare
ee7350f to
812b1bc
Compare
8f5d36a to
147f331
Compare
812b1bc to
935bd01
Compare
9c1cbd4 to
5896058
Compare
935bd01 to
eb67fba
Compare
cyrus-
requested changes
Feb 10, 2026
Member
cyrus-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the up triangle in the pop up UI has a different height causing jitter in the UI when clicked on
- proofs about built in map (and presumably other built ins) not going through
- when check is valid, insert it immediately (also for algebrite)
- run checks on every edit rather than when clicked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a setting that forces the user to write out steps in the prover