Skip to content

Conversation

@7h3kk1d
Copy link
Contributor

@7h3kk1d 7h3kk1d commented Feb 9, 2026

  • Exp.cls_of_term shows cls of underlying expression if projector
  • Cursor inspector still shows projector info on left side

@7h3kk1d 7h3kk1d requested a review from disconcision February 9, 2026 23:10
@7h3kk1d 7h3kk1d linked an issue Feb 9, 2026 that may be closed by this pull request
@7h3kk1d 7h3kk1d changed the title Fix #2166 Fixes #2166 Feb 9, 2026
- Exp.cls_of_term shows cls of underlying expression if projector
- Cursor inspector still shows projector info on left side
@7h3kk1d 7h3kk1d force-pushed the 2116-cant-add-projectors-around-inconsistent-types branch from daf4f67 to 6520842 Compare February 9, 2026 23:11
@7h3kk1d
Copy link
Contributor Author

7h3kk1d commented Feb 9, 2026

@disconcision I did the most tactical thing here. I'm not sure what we want cls on info/expression to be. This still uses the override in the cursor inspector to show the projector info but now error messages have the underlying expressions cls.

Sidenote, this just reaffirms my belief that building all this stuff in statics makes more sense than a set of attributes that are universally applicable.

@disconcision
Copy link
Member

building all this stuff in statics

like building the CI in statics? yeah probably reasonable at this point

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.34%. Comparing base (062397c) to head (41c2505).
⚠️ Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
src/language/term/Exp.re 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2117      +/-   ##
==========================================
- Coverage   50.40%   50.34%   -0.06%     
==========================================
  Files         230      230              
  Lines       25365    25365              
==========================================
- Hits        12784    12771      -13     
- Misses      12581    12594      +13     
Files with missing lines Coverage Δ
src/language/term/Exp.re 72.20% <0.00%> (-1.21%) ⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyrus- cyrus- merged commit 77ab798 into dev Feb 10, 2026
4 checks passed
@cyrus- cyrus- deleted the 2116-cant-add-projectors-around-inconsistent-types branch February 10, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't add projectors around inconsistent types

3 participants