Imports refactoring #1815

o-murphy · 2025-08-21T08:04:48Z

This PR is solving #1813 issue and preparing project to resolve #1812

Changed

build_and_test.yml workflow_dispatch trigger added
~~Updated typing_extensions dependency platform flags~~
Simplified conditional imports from typing with alternatives from typing_extensions
that resolves it under the hood, so we need no control it manually
~~Legacy collections.abc imports replaced with typing_extensions~~
cause current required typing_extensions>=4.7 version already supports all them
~~Removed redundant (legacy) imports from __future__~~
Undefined annotations fixed

Added

Added _compat.py module to simplify future support for other python implementations, like pypy or circuitpython

Changed ------- - `build_and_test.yml` workflow_dispatch trigger added - Updated `typing_extensions` dependency platform flags - Simplified conditional imports from `typing` with alternatives from `typing_extensions` that resolves it under the hood, so we need no control it manually - Legacy `collections.abc` imports replaced with `typing_extensions` cause current required `typing_extensions>=4.7` version already supports all them - Removed redundant (legacy) imports from `__future__` - Undefined annotations fixed Added ----- - Added `_compat.py` module to simplify future support for other python implementations, like `pypy` or `circuitpython`

dlech

If there was some new typing feature that we would need typing_extensions for in more recent versions of Python, I could be convinced to not make it a conditional dependency. But as it is, I think this PR is too heavy-handed in undoing things that were intentionally done (see inline comments).

bleak/__init__.py

dlech · 2025-08-21T13:02:16Z

bleak/__init__.py

 import os
 import sys
 import uuid
-from collections.abc import AsyncGenerator, Awaitable, Callable, Iterable


collections.abc is the canonical place to import these from since Python 3.9, so this feels like a step backwards as well.

Agree, but the problem this types are defined in different places for each python versions starting from 3.9, so if we know typing_extensions are duarantee reimport it as needed for each version why should we do it by ourself?

Till old python versions support will be done it looks quite good to use backward compatibility through typing_extensions instead of conditional imports.
Besides, I have great doubts that you will completely abandon typing_extension in the next few years.

We have already dropped support for Python < 3.9, so I don't see why we would need to change this. typing_extensions just forwards typing declarations of these types and these types are deprecated in the typing module.

That’s why it’s logical. Instead of doing it manually in each individual module, you use a tool that does it under the hood, allowing you to focus on implementation rather than annotation compatibility. Why are you so sceptical to typing_extensions?

rolled back

Why are you so sceptical to typing_extensions?

Not skeptical. One of the original core design decisions of Bleak was minimal dependencies. So that has been what has guided the current state of things.

dlech · 2025-08-21T21:29:21Z

pyproject.toml

 [tool.poetry.dependencies]
 async-timeout = { version = ">=3.0.0", python = "<3.11" }
-typing-extensions = { version = ">=4.7.0", python = "<3.12" }
+typing-extensions = { version = ">=4.7.0" }


Ideally, we would drop the typing-extensions dependency in a few years when we drop support for Python 3.11. This is why we have the extra conditionals in the code and here.

That is, but if you wanna conditional imports it would be a good practice then place it inside _compat.py module. You have such much this along the codebase

Till 3.11 will be dropped I propose use typing_extensions directly, that is almost affects nothing except readability, but makes maintenance and extending simplier

o-murphy · 2025-08-21T22:01:44Z

If there was some new typing feature that we would need typing_extensions for in more recent versions of Python, I could be convinced to not make it a conditional dependency. But as it is, I think this PR is too heavy-handed in undoing things that were intentionally done (see inline comments).

If it's that fundamental, then the general practice is: "It's easier to ask for forgiveness than permission" so instead of if/else there should be try/except ImportError. I can refactor to this purpose, but take a look on my review replies

o-murphy · 2025-08-22T07:58:06Z

@dlech

How can you explain that you mix your own version-based resolving with forwards from typing_extensions? Why don't you rely entirely on a self-written implementation then?

dlech · 2025-08-22T12:35:08Z

Why don't you rely entirely on a self-written implementation then?

typing_extensions is handled as a special case by static analysis tools, so I don't think vendoring just the parts we need is an option.

bleak/__init__.py

o-murphy · 2025-08-22T14:34:06Z

bleak/backends/scanner.py


 # prevent tasks from being garbage collected
-_background_tasks = set[asyncio.Task[None]]()
+_background_tasks: set[asyncio.Task[None]] = set()


Same as in init

o-murphy · 2025-08-22T14:35:33Z

bleak/__init__.py

        .. versionadded:: 0.21
        """
-        devices = asyncio.Queue[tuple[BLEDevice, AdvertisementData]]()
+        devices: asyncio.Queue[tuple[BLEDevice, AdvertisementData]] = asyncio.Queue()


Same as previous

o-murphy · 2025-08-22T14:36:21Z

@dlech
Ok can we at least make annotation changes as I made in last commit?

o-murphy · 2025-08-23T19:14:56Z

@dlech
I looked again at PEPs 649, 749 and 563, and it looks like PEP649 and PEP749 were not implemented until 3.14, i.e. for versions <3.14 from __future__ import annotations works according to PEP563. From the point of view of PEP563, converting all annotations to strings and reproducing types from string representation during type checking seemed more efficient than calculating annotations at runtime, but it allowed writing arbitrary expressions in annotations, which is also strange. Considering that most annotations are correctly written and only in 2 or 3 lines in the code I found unbound variables in annotations. From the point of view of preparing for PEP649 in 3.14, it would probably be more correct to wrap only these annotations in strings, or to introduce bounded typevar to have normal references in the annotation dictionary

pep-0749
In Python 3.14, from future import annotations will continue to work as it did before, converting annotations into strings.

o-murphy · 2025-08-23T19:26:46Z

So, regarding the drama surrounding PEP563 and Guido's decision at the time,
__future__.annoations will never be "future" and will remain here, in version 3.14, for backwards compatibility, but it would not be an expected sollution. The feature will be deprecated after so many years without ever getting the right to live.

o-murphy force-pushed the imports-refactoring branch from dfa1a49 to ad21cb6 Compare August 21, 2025 08:08

o-murphy force-pushed the imports-refactoring branch from ad21cb6 to 952f579 Compare August 21, 2025 08:48

o-murphy marked this pull request as ready for review August 21, 2025 08:51

This was referenced Aug 21, 2025

Too much repeating conditional imports #1813

Open

CircuitPython backend: WIP #1814

Draft

dlech reviewed Aug 21, 2025

View reviewed changes

rollback collections.abc imports

a744a60

o-murphy force-pushed the imports-refactoring branch from 17192c7 to a744a60 Compare August 22, 2025 08:03

annotations changed

5f6d80b

o-murphy commented Aug 22, 2025

View reviewed changes

bleak/__init__.py Show resolved Hide resolved

o-murphy commented Aug 22, 2025

View reviewed changes

o-murphy requested a review from dlech August 23, 2025 22:04

Imports refactoring #1815

Are you sure you want to change the base?

Imports refactoring #1815

Uh oh!

Conversation

o-murphy commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changed

Added

Uh oh!

dlech left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

o-murphy Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

o-murphy commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

o-murphy commented Aug 22, 2025

Uh oh!

dlech commented Aug 22, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

o-murphy commented Aug 22, 2025

Uh oh!

o-murphy commented Aug 23, 2025

Uh oh!

o-murphy commented Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

o-murphy commented Aug 21, 2025 •

edited

Loading

o-murphy Aug 22, 2025 •

edited

Loading

o-murphy commented Aug 21, 2025 •

edited

Loading

o-murphy commented Aug 23, 2025 •

edited

Loading