Skip to content

Fixes stuck deployment #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kube/account/account-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ spec:
name: huly-secret
key: SERVER_SECRET
- name: TRANSACTOR_URL
value: ws://transactor:3333;ws://localhost:3333
valueFrom:
configMapKeyRef:
name: huly-config
key: TRANSACTOR_URL
Comment on lines -59 to +62

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay unchanged, account pod doesn't need to use ingress to reach transactor service.
TRANSACTOR_URL in config needs to be used by frontend. That change should be done in frontend code, not in deployment manifests. Last time I checked it (front pod) was using localhost which would cause problem when reaching frontend through proxy.

- name: ENDPOINT_URL
valueFrom:
configMapKeyRef:
Expand Down
7 changes: 5 additions & 2 deletions kube/transactor/transactor-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,22 @@ kind: Ingress
metadata:
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
nginx.ingress.kubernetes.io/enable-websocket: "true"
labels:
app: transactor
name: transactor
spec:
ingressClassName: nginx
rules:
- host: transactor.huly.example
- host: transactor.tributor.in
http:
paths:
- backend:
service:
name: transactor
port:
number: 80
number: 3333 # Updated port number to match the service port
path: /
pathType: Prefix
3 changes: 2 additions & 1 deletion kube/transactor/transactor-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ metadata:
name: transactor
spec:
ports:
- port: 80
- port: 3333
protocol: TCP
targetPort: 3333
selector:
app: transactor
type: ClusterIP