Basic rate limits #8539
Open
Basic rate limits #8539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Sobolev <[email protected]>
aonnikov
reviewed
Apr 15, 2025
| retryAfter != null | ||
| ? parseInt(retryAfter, 10) | ||
| : rateLimitReset != null | ||
| ? new Date(parseInt(rateLimitReset, 10)).getTime() - Date.now() |
There was a problem hiding this comment.
Maybe do something like this:
Math.max(new Date(parseInt(rateLimitReset, Date.now())).getTime() - Date.now()), 10)
aonnikov
reviewed
Apr 15, 2025
|
|
||
| console.warn(`Rate limit exceeded. Waiting ${waitTime / 1000} seconds before retrying...`) | ||
| await new Promise((resolve) => setTimeout(resolve, waitTime)) | ||
| throw new Error(rateLimitError) |
There was a problem hiding this comment.
throw after waiting for timeout? I think we should either throw an error or wait, not both. If we waited for XX seconds, then we can safely do requests again
aonnikov
approved these changes
Apr 15, 2025
|
|
||
| console.warn(`Rate limit exceeded. Waiting ${waitTime / 1000} seconds before retrying...`) | ||
| await new Promise((resolve) => setTimeout(resolve, waitTime)) | ||
| throw new Error(rateLimitError) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic rate limits