-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Office dynamic participants layout #9994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Anton Alexeyev <[email protected]>
Signed-off-by: Anton Alexeyev <[email protected]>
Connected to Huly®: UBERF-13832 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new dynamic participants layout for Office meetings with automatic grid positioning based on container size and participant count. The layout replaces the previous fixed grid system with an adaptive algorithm that optimizes tile sizes and column counts.
- New dynamic grid layout algorithm that calculates optimal tile sizes and column arrangements
- Removed conditional video tab creation and simplified meeting widget setup
- Enhanced responsive design with proper aspect ratio handling and ResizeObserver integration
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
plugins/love-resources/src/utils.ts |
Simplified createMeetingWidget to always include video tab |
plugins/love-resources/src/types.ts |
Removed unused DefSeparators import and loveSeparators constant |
plugins/love-resources/src/components/meeting/widget/VideoTab.svelte |
Added height: 100% to container styling |
plugins/love-resources/src/components/meeting/ParticipantsListView.svelte |
Major refactor with dynamic grid layout algorithm and ResizeObserver |
plugins/love-resources/src/components/meeting/ControlExt.svelte |
Updated createMeetingWidget call to remove video parameter |
plugins/love-resources/src/components/meeting/ControlBarContainer.svelte |
Fixed hardcoded gap value in responsive styles |
plugins/love-resources/src/components/VideoPopup.svelte |
Replaced Scroller with direct div and simplified layout structure |
plugins/love-resources/src/components/Room.svelte |
Complete layout restructure with new separator system and responsive design |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
An experimental version of the new meeting layout. The PR is primarily intended to gather feedback, and if the reaction is positive, it will be further refined.

