Update evaluate InfPool readiness#2
Merged
hdefazio merged 1 commit intohdefazio:dev/inferencepool_condsfrom Aug 21, 2025
Merged
Update evaluate InfPool readiness#2hdefazio merged 1 commit intohdefazio:dev/inferencepool_condsfrom
hdefazio merged 1 commit intohdefazio:dev/inferencepool_condsfrom
Conversation
- InferencePool is only one (either a ref or a embedded Spec) - Updated ensureRouterManagedResourcesAreReady to also make InfPool ready - Update logic for IsInferencePool ready to be consistent with the HTTPRoute logic and evaluate all parents to be Accepted - Removed the embedded InfPool test as it's already covered in other schenarios where `Scheduler != nil` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
dev/inferencepool_conds
branch
from
3171f4c to
c53433a
Compare
5 tasks
hdefazio
merged commit fc46702
into
hdefazio:dev/inferencepool_conds
24 of 26 checks passed
hdefazio
added a commit
that referenced
this pull request
Oct 9, 2025
* Add InferencePoolsReady as a subcondition to RouterReady Signed-off-by: Hannah DeFazio <h2defazio@gmail.com> * Add test, actually call EvaluateInferencePoolConditions so it does something Signed-off-by: Hannah DeFazio <h2defazio@gmail.com> * Update evaluate InfPool readiness (#2) - InferencePool is only one (either a ref or a embedded Spec) - Updated ensureRouterManagedResourcesAreReady to also make InfPool ready - Update logic for IsInferencePool ready to be consistent with the HTTPRoute logic and evaluate all parents to be Accepted - Removed the embedded InfPool test as it's already covered in other schenarios where `Scheduler != nil` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Hannah DeFazio <h2defazio@gmail.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler != nilFeel free to review, ask questions and make changes, once we merge this PR, the original PR will get updated automatically