Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Hide row actions with hidden columns #2968

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

frontend: Hide row actions with hidden columns #2968

wants to merge 2 commits into from

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Mar 3, 2025 •
edited
Loading

This change ensures that when all of the non-action columns are hidden, the action column is also hidden.

Fixes: #2932

Testing

  • Navigate to the Headlamp home page
  • Manually hide all the cluster fields in the table
  • Ensure that the row actions are also hidden
  • Manually unhide one field and ensure that the row actions appear again

@skoeva skoeva added bug Something isn't working frontend Issues related to the frontend labels Mar 3, 2025
@skoeva skoeva self-assigned this Mar 3, 2025
@skoeva skoeva linked an issue Mar 3, 2025 that may be closed by this pull request
Clusters list table is visible even if all properties are hidden #2932
Open
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 3, 2025
@sniok
Copy link
Contributor

sniok commented Mar 4, 2025

Could you also remove the sorting from the actions column? I've just noticed it
image

@skoeva skoeva changed the title frontend: Table: Hide rows with hidden columns frontend: Home: Hide row actions with hidden columns Mar 5, 2025
@skoeva
frontend: Home: Add id to actions column
950f656 
Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva changed the title frontend: Home: Hide row actions with hidden columns frontend: Hide row actions with hidden columns Mar 5, 2025
@skoeva
Copy link
Contributor Author

skoeva commented Mar 5, 2025

Turns out the issue was isolated to the actions column as you pointed out @sniok, but it looks like this behavior is expected according to the MRT docs.

Still think this might be a UX improvement, so PR has been updated

@sniok
Copy link
Contributor

sniok commented Mar 5, 2025

Turns out the issue was isolated to the actions column as you pointed out @sniok, but it looks like this behavior is expected according to the MRT docs.

Still think this might be a UX improvement, so PR has been updated

I was just referring to the sorting button on the actions column. To be honest I don't think we should worry too much about the case when all the columns are hidden because what's the point of not showing any column

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skoeva skoeva

Labels
bug Something isn't working frontend Issues related to the frontend size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Release Plan / Roadmap
Status: Queued
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clusters list table is visible even if all properties are hidden
2 participants
@skoeva @sniok