frontend: Hide row actions with hidden columns #2968
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
Could you also remove the sorting from the actions column? I've just noticed it |
skoeva
changed the title
Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva
changed the title
Signed-off-by: Evangelos Skopelitis <[email protected]>
|
Turns out the issue was isolated to the actions column as you pointed out @sniok, but it looks like this behavior is expected according to the MRT docs. Still think this might be a UX improvement, so PR has been updated |
I was just referring to the sorting button on the actions column. To be honest I don't think we should worry too much about the case when all the columns are hidden because what's the point of not showing any column |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that when all of the non-action columns are hidden, the action column is also hidden.
Fixes: #2932
Testing