Skip to content

Conversation

@friedrichatgc
Copy link

This new typedef must be one of

  • explicit_system_tag
  • second_order_system_tag
  • symplectic_system_tag
  • simple_symplectic_system_tag
  • symplectic_or_simple_symplectic_system_tag
  • implicit_system_tag
    and defines the type of the system the stepper handles.
    This can be usefull to automatically provide a proper system to a
    stepper using template spezialization.

Markus Friedrich added 2 commits January 8, 2018 19:50
This new typedef must be one of
- explicit_system_tag
- second_order_system_tag
- symplectic_system_tag
- simple_symplectic_system_tag
- symplectic_or_simple_symplectic_system_tag
- implicit_system_tag
and defines the type of the system the stepper handles.
This can be usefull to automatically provide a proper system to a
stepper using template spezialization.
* These tags can be used to detect which system category is used
*/

struct explicit_system_tag {};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to define the interface expected from the different system functor here!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How? Just as (doxygen) comments?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just a short doxy showing how this interface is being called from inside the corresponding stepper.

struct second_order_system_tag {};
struct symplectic_system_tag {};
struct simple_symplectic_system_tag {};
struct symplectic_or_simple_symplectic_system_tag {};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need 3 versions of symplectic tags? It seems only the last one is being used? If we keep all 3, shouldn't the last be derived from the two above to express the is_a relation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently all symplectic steppers support both "normal"- and simple-simplectic systems. So just having symplectic_or_simple_symplectic_system_tag is fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants