Issues/149 - rework of navigation component #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obile menu on tablet
|
Develop merge into this branch and tested locally, good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This adds more functionality for the navigation component with new abilities to customize. Also improves mobile and tablet navigation experience, before mobile weren't usable because of hover effects. Now there is a list of dropdowns that the user can click.
New Dialog:
toggletype = accordion: links open one at a time
= toggle: links can open all at once
showmobilemenuontablet = if true then shows hambuger menu on tablet screens
mobiledropdownbg = if true turns mobile nested list backgrounds to transparent
levels = choose how many levels of nesting
Does this close any currently open issues?
#149
Where has this been tested?
Locally,
✅ Regression tested nav component
There won't be multiple navigation bars next to each other, so the overlapping effect shouldn't be an issue.
Desktop video:
Tablet video:
Mobile video:
Browser (version): Chrome v84