Fix misleading comment in README about browser_validations default#1869
Closed
55728 wants to merge 1 commit into
Closed
Fix misleading comment in README about browser_validations default#186955728 wants to merge 1 commit into
55728 wants to merge 1 commit into
Conversation
Author
|
Closing this as stale. Happy to reopen if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README contains a code example with a comment stating
# default is true:While
trueis the default inlib/simple_form.rb, the generator intentionally sets it tofalsein the initializer (see #319). This has caused recurring confusion, as reported in #1216 and #1746.This PR removes the misleading inline comment so that users are not led to believe their app is running with
browser_validations = trueafter running the generator.Fixes #1746