Add Hebrew language support #711
Open
+1,646
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive Hebrew translation support including book names,
verse numbers using Hebrew letters, and reading summaries.
New Features:
- Hebrew translations for all Torah, Nevi'im, and Ketuvim book names
- Hebrew numerals (gematria) for chapter and verse references
- Hebrew translations for holiday and special reading names
- Language parameter added to core API functions
- Special handling for numbers 15 and 16 to avoid spelling God's name
Core Changes:
- Add numberToHebrew() function for converting numbers to Hebrew numerals
- Add formatVerseToHebrew() to format verse references
- Add translateAliyah() and translateAliyahOrArray() helper functions
- Add translateLeyning() to translate complete Leyning objects
- Extend getLeyningForParsha() to accept language parameter
- Extend getLeyningForHoliday() to accept language parameter
- Extend getLeyningOnDate() to accept language parameter
Data:
- Add po/he.po with 160+ Hebrew translations
- Add HEBREW_NUMERALS mapping for gematria conversion
Tests:
- Add 147 new test cases for Hebrew translations
- Test formatVerseToHebrew() with edge cases and special numbers
- Test formatAliyahShort() in both English and Hebrew
- Test Hebrew translations for parshiot, holidays, and haftarot
API Changes (backward compatible):
- All translation functions default to English ('en')
- Existing code continues to work without modifications
- New optional language parameter on public functions
Example usage:
const reading = getLeyningForParsha('Pinchas', 'he');
// reading.summary = 'בְּמִדְבַּר כה:י-ל:א'
// reading.fullkriyah['1'].k = 'בְּמִדְבַּר'
// reading.haftara = 'מְלָכִים א יח:מו-יט:כא'
Contributor
Author
|
@mjradwin tell me if I need to change things. I tried to make so new languages will be easy to add. |
Member
|
Thank you. I am starting to review. At a minimum we would want to reuse the https://hebcal.github.io/api/hdate/functions/gematriya.html You would have to replace the geresh or gershayim characters but this is easy to do |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive Hebrew translation support including book names, verse numbers using Hebrew letters, and reading summaries.
New Features:
Core Changes:
Data:
Tests:
API Changes (backward compatible):
Example usage:
const reading = getLeyningForParsha('Pinchas', 'he'); // reading.summary = 'בְּמִדְבַּר כה:י-ל:א' // reading.fullkriyah['1'].k = 'בְּמִדְבַּר' // reading.haftara = 'מְלָכִים א יח:מו-יט:כא'