Skip to content

feat(commandbridge): materialize ACP prompt resources - #26

Merged
chicoxyzzy merged 9 commits into
mainfrom
feat/acp-resource-inputs
Jul 17, 2026
Merged

feat(commandbridge): materialize ACP prompt resources#26
chicoxyzzy merged 9 commits into
mainfrom
feat/acp-resource-inputs

Conversation

@chicoxyzzy

@chicoxyzzy chicoxyzzy commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

Add a provider-neutral boundary for file and rich ACP prompt inputs in command-backed adapters.

The bridge now:

  • validates image, audio, embedded-resource, and local resource-link inputs
  • materializes accepted local content in a private prompt-scoped directory
  • exposes ordered typed inputs to command builders
  • preserves remote resource links as unfetched metadata
  • removes the private stage after the turn, including cancellation paths

Safety and privacy

  • bounds block counts, individual inputs, and total materialized bytes
  • rejects unsupported or ambiguous local paths before launching a provider
  • uses private POSIX modes and protected Windows ACLs
  • prevents source-local identifiers and stage aliases from leaking through prompts, errors, updates, tool activity, permission requests, or transcripts
  • serializes prompt ownership so stale cancellation or cleanup cannot affect a later turn
  • fails the prompt if protected cleanup cannot complete, while retaining the guards needed for safe manual recovery

Compatibility

Existing text-only builders remain compatible. Builders that consume prepared rich inputs can use RequirePromptText or PreparedPromptInputs. The exported EmbeddedResource.Kind field makes the first release containing this change v0.2.0.

This branch has been rebased onto current main and preserves the newer native-session failure classification and process-containment behavior.

Verification

  • go test ./...
  • go vet ./...
  • go test -race -timeout 10m ./...
  • Windows, Linux, Darwin, and FreeBSD cross-compilation
  • Windows cross-vet
  • native Darwin ACL and mount checks
  • native Windows ACL, reparse-point, restrictive-reader, and exact-cleanup checks
  • focused cancellation, UTF-8 boundary, finalization, and cleanup regressions
  • go mod tidy
  • git diff --check
  • exact head under review: e42875248155b041baa7ddf54f16ad196e1f5511

@chicoxyzzy
chicoxyzzy marked this pull request as ready for review July 15, 2026 19:56
@chicoxyzzy
chicoxyzzy force-pushed the feat/acp-resource-inputs branch from f882e54 to e428752 Compare July 17, 2026 11:24
@chicoxyzzy
chicoxyzzy merged commit 80393ec into main Jul 17, 2026
3 checks passed
@chicoxyzzy
chicoxyzzy deleted the feat/acp-resource-inputs branch July 17, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant