feat(assignments): add recoverable claim leases - #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Atomic assignment transitions prevented double claims, but a host crash after
assignments.claimcould still strand work indefinitely. Expiry alone would be unsafe because a stale worker could mutate a later claim generation.This change leases only the pre-start
claimedreservation and fences every later worker lifecycle write. Once work starts, the lease expiry is retired and Cairnline continues to treat runtime recovery as host-owned.Contract and migration
assignments.claimnow returnsclaim.id,acquired_at, andexpires_atin structured content, with the ID also present in fallback text.assignments.prepareandassignments.releasetakeclaim_idinstead ofclaimed_by;assignments.update_statusandassignments.completerequire it.assignments.renew_claimandassignments.recover_claimare new.Storeinterface adds leased/fenced methods, so custom stores must implement them.Safety properties
running,awaiting_approval, orawaiting_reviewworkValidation
go build ./...go test -count=1 ./...go vet ./...go test -race -count=1 -timeout 10m ./...bun run buildbun run typecheckbun run testbun run lintbun run format:check