fix(chats): resolve task approvals optimistically before the API returns

[chicoxyzzy]

Summary

The Hecate Chat task-approval banner cleared a row only AFTER the network round-trip completed (`useRuntimeConsole.ts:1602` ➝ `await resolveTaskApprovalRequest(...)` ➝ patch). On slow links the row sat there post-click looking unresponsive, and a double-click could fire a duplicate POST through the busy-disabled buttons (since `disabled` only flipped on after the busy state propagated through React's render cycle).

Move the optimistic patch BEFORE the API call:

```
snapshot = activeAgentChatSession // sync from closure, like deleteProvider
patch the local state // banner row disappears immediately
try { await api(); maybe refresh } catch { restore from snapshot }
```

Capturing the snapshot inside the state-updater would not work: React invokes useState updaters asynchronously, and may invoke them twice under StrictMode, so a closure variable assigned inside the updater is either still null when the catch runs or already holds the patched state. Reading from the destructured `activeAgentChatSession` closure is the same synchronous-snapshot pattern `deleteProvider` uses (`useRuntimeConsole.ts:1265`).

Concurrency-safe rollback

• The rollback uses a functional updater that bails when `current.id !== snapshot.id` — so if the operator navigated to another session while the API was in flight, the rollback no-ops instead of yanking them back.
• It restores ONLY the specific approval activity from the snapshot (matched by `approval_id` or the projected `task:approval:` id, never by the optional `Activity.id`), so any new messages / activities that arrived during the await are preserved.

Failure handling

• Generic failure → rollback + error notice. Operator can retry.
• `/not pending/i` error → server says "already resolved upstream", but possibly to a different decision than the operator picked. Refresh the session to pull server-truth; if the refresh succeeds, server data wins. If the refresh ALSO fails, fall through to the same rollback so the row reflects "still pending" rather than a possibly-wrong final state, plus an error notice telling the operator to reload.

Test plan

Five new tests in `useRuntimeConsole.test.tsx` cover every code path:

• `optimistically marks the row resolved before the API call returns` — uses a deferred Promise so the fetch is still in flight when the assertion runs; verifies `activity.status === "approved"` while `resolveResolveCall` has NOT been called yet.
• `rolls back the optimistic patch when the API rejects` — 500 response, asserts the activity reverts to `awaiting_approval` and an error notice surfaces.
• `rollback restores the right activity when activity.id is absent` — id-less thinking row + id-less approval row in the same message; only the approval is restored, the thinking row stays untouched.
• `rollback does not clobber a session the operator switched to mid-flight` — operator switches a1 → a2 while the resolve hangs; API rejects; active session must stay a2 (functional updater bails on id mismatch).
• `rolls back when the server says 'not pending' and the refresh also fails` — 409 not-pending plus a 503 on the follow-up refresh; expect `ok === false`, status restored to `awaiting_approval`, error notice.

Plus:

• `tsc --build` — clean for production code (`useRuntimeConsole.ts`); 6 pre-existing baseline errors in unrelated test files & tsconfig.node.json that were there before this PR.
• Full UI suite: 652 passes, 0 failures.

What's NOT in this PR

The "resolved approvals should not be clickable" half of the original ask was already covered (existing test at `ChatView.test.tsx:1167` pins the behavior — `status === "approved"` doesn't render the banner, the resolve buttons are gone). The remaining gap was the click-to-disappear latency, which this PR closes.

[Copilot]

Pull request overview

Improves Hecate Chat task-approval UX by applying an optimistic local state update so the approval banner row disappears immediately on click, then reconciling with the backend response.

Changes:

• Apply the task-approval “resolved” patch to activeAgentChatSession before calling the resolve API, with rollback on failure.
• Add tests covering (1) optimistic UI update before the network resolves and (2) rollback behavior when the API rejects.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
ui/src/app/useRuntimeConsole.ts	Moves the optimistic “resolve” patch ahead of the API call and adds rollback logic.
ui/src/app/useRuntimeConsole.test.tsx	Adds two tests to pin optimistic-update timing and rollback behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.