[generate:entity:content] Improve command options#3371
Open
derhasi wants to merge 2 commits intohechoendrupal:masterfrom
Open
[generate:entity:content] Improve command options#3371derhasi wants to merge 2 commits intohechoendrupal:masterfrom
derhasi wants to merge 2 commits intohechoendrupal:masterfrom
Conversation
Member
|
@derhasi thanks for the PR. By setting an option as Not sure if we should ask for those options on the interactive mode, can we just used them as false. |
Contributor
Author
|
@jmolivas I think the option always should be asked for interactively, when it was not explicitly set in the command line. But as you cannot pass a value to an option that is set to |
Contributor
Author
|
The implementation of this PR would result in ...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current
drupal generate:entity:contentcommand there are some problems, so you could not generate an entity without any manual confirmation step. The base-path set via--base-path="..."currently only is set as default for the question displayed after running the command. With the optionshas-bundles,is-translatableandrevisionablethere is the problem of not beeing able to disable those settings via the command line.With the given PR I try to fix those problems, so a command like below, will run without the need of any manual confirmations:
The PR adds the possibility to disable an option by setting it to 0 or false.