[generate:command] Regression with the Annotation stops custom translations from working#4282
Open
codebymikey wants to merge 1 commit intohechoendrupal:masterfrom
Open
[generate:command] Regression with the Annotation stops custom translations from working#4282codebymikey wants to merge 1 commit intohechoendrupal:masterfrom
codebymikey wants to merge 1 commit intohechoendrupal:masterfrom
Conversation
The DrupalCommand annotation was missing the '@' annotation token. This stops translations from being detected for generated commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #4074 PR introduced a regression with the annotations.
The
DrupalCommandannotation was missing the@annotation token prefix, which stops translations from being detected for generated commands as it fails validation and marked as an invalid command in the following:drupal-console/src/Application.php
Lines 123 to 129 in e582d88