Skip to content

[generate:command] Regression with the Annotation stops custom translations from working#4282

Open
codebymikey wants to merge 1 commit intohechoendrupal:masterfrom
codebymikey:patch-1
Open

[generate:command] Regression with the Annotation stops custom translations from working#4282
codebymikey wants to merge 1 commit intohechoendrupal:masterfrom
codebymikey:patch-1

Conversation

@codebymikey
Copy link

The #4074 PR introduced a regression with the annotations.

The DrupalCommand annotation was missing the @ annotation token prefix, which stops translations from being detected for generated commands as it fails validation and marked as an invalid command in the following:

if (!$annotationValidator->isValidCommand(
$serviceDefinition->getClass()
)
) {
$invalidCommands[] = $name;
continue;
}

The DrupalCommand annotation was missing the '@' annotation token.
This stops translations from being detected for generated commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments