Update SDL(2) Submodule to 2.32.x Release branch #1449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when UnleashedRecomp was released, it was running on SDL2 2.29.2 pre-release, this ultimately become 2.30.0. To closely align with the most up-to-date version of SDL2 and SDL2 Mixer: the submodule for both of them has been updated to be based on the 2.32.X branch. Specifically: SDL Version 2.32.2-9-g2708e08f4, and SDL2_mixer 2.8.1.
Contributor
Author
|
Will be closing this PR for the time being, in favor of letting the maintainers to do the submodule update instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when UnleashedRecomp was initially released, it was running on SDL2 2.29.2 pre-release. This ultimately become a "release candidate" for Version 2.30.0.
To closely align with the most up-to-date version of SDL2 and SDL2 Mixer: the submodule for both has been updated to be based on the 2.32.X branch.
Specifically: SDL Version 2.32.2-9-g2708e08f4, and SDL2_mixer 2.8.1. Both are considered the release build of SDL2, and the most up-to-date SDL2 yet. Since this project doesn't rely on "SDL2.dll" file for dynamic runtime (as far as I can tell), updating the submodule might be far more suitable for the time being.