Skip to content

Conversation

@AL2009man
Copy link
Contributor

@AL2009man AL2009man commented May 1, 2025

This is a poor man's attempt on addressing GitHub Action doesn't respect Pull Requests and it's branches while validating. #1311

As this simple change might break GitHub Actions in the process, serious verification will be needed first. For now: this will be a Draft PR.

@squidbus
Copy link
Contributor

squidbus commented May 1, 2025

I think the issue here is simply that this repository is using pull_request_target instead of pull_request as the action trigger. Although maybe that is needed because of the private repo, so I guess that's why this workaround is needed here.

@AL2009man AL2009man marked this pull request as ready for review May 19, 2025 22:57
@AL2009man
Copy link
Contributor Author

I think the issue here is simply that this repository is using pull_request_target instead of pull_request as the action trigger. Although maybe that is needed because of the private repo, so I guess that's why this workaround is needed here.

hm...I'm going to open this PR for review, if anyone wanna look into it. unfortunately, I can't fully test nor verify myself til then.

@squidbus
Copy link
Contributor

squidbus commented Aug 1, 2025

Bit late on this but one thing: if the repo is using pull_request_target instead of just pull_request out of security concerns with CI secrets or private files, I don't think it will be possible to have PR CI build since even if you avoid running the PR branch CI workflows, as long as you are running build scripts from the PR branch they can do whatever.

So I think either it should just get changed to pull_request maybe with some trusted user authorization or there shouldn't be a PR build at all, doing something like this doesn't solve the reason for not just using pull_request.

@AL2009man AL2009man marked this pull request as draft August 1, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants