Use different seed for each property #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodmosaic
approved these changes
Dec 3, 2025
Member
moodmosaic
left a comment
moodmosaic
left a comment
There was a problem hiding this comment.
LGTM! The bug was caused by sharing a single, memoized initial state across all properties. Instead, every property check should get a fresh, unique initial state (which is what this PR fixes). Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at #451 to understand why it happens.
Turns out it happens because
PropertyArgs.initis a value, and not a funciton.Which means that it does start with the random seed, but all the properties in a run use the same random seed.
This causes different properties generating the same values.
@moodmosaic I am not sure if it is a bug or a feature. From my PoV it is a bug :)
If you agree, here is the fix.