-
Notifications
You must be signed in to change notification settings - Fork 29
Add Property.ignoreResult combinator #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| module Hedgehog.Tests.TryWithTryFinallyTests | ||
|
|
||
| open Hedgehog | ||
| open Hedgehog.FSharp | ||
| open TestDsl | ||
|
|
||
| // Simulate fluent assertion library for testing | ||
| type AssertionResult = { Success: bool } | ||
| let shouldBe expected actual = | ||
| if actual = expected then { Success = true } | ||
| else failwithf $"Expected %d{expected} but got %d{actual}" | ||
|
|
||
| /// Tests for Property.tryFinally and Property.ignoreResult | ||
| let tryWithTryFinallyTests = testList "Property.tryFinally and ignoreResult tests" [ | ||
|
|
||
| testCase "tryFinally cleanup runs on success" <| fun () -> | ||
| let mutable cleanupCalled = false | ||
| property { | ||
| let! x = Gen.constant 42 | ||
| return x = 42 | ||
| } | ||
| |> Property.tryFinally (fun () -> cleanupCalled <- true) | ||
| |> Property.checkBool | ||
|
|
||
| Expect.isTrue cleanupCalled | ||
|
|
||
| testCase "tryFinally cleanup runs on failure" <| fun () -> | ||
| let mutable cleanupCalled = false | ||
| let report = | ||
| property { | ||
| let! x = Gen.constant 42 | ||
| return false | ||
| } | ||
| |> Property.tryFinally (fun () -> cleanupCalled <- true) | ||
| |> Property.reportBool | ||
|
|
||
| match report.Status with | ||
| | Failed _ -> () | ||
| | _ -> failwith "Expected Failed status" | ||
|
|
||
| Expect.isTrue cleanupCalled | ||
|
|
||
| testCase "ignoreResult converts Property<'a> to Property<unit>" <| fun () -> | ||
| let mutable testRan = false | ||
| property { | ||
| let! x = Gen.constant 42 | ||
| testRan <- true | ||
| return shouldBe 42 x // Returns AssertionResult | ||
| } | ||
| |> Property.ignoreResult // Convert to Property<unit> | ||
| |> Property.check | ||
|
|
||
|
|
||
| testCase "ignoreResult preserves failures" <| fun () -> | ||
| let report = | ||
| property { | ||
| let! x = Gen.constant 42 | ||
| return shouldBe 99 x // Will throw | ||
| } | ||
| |> Property.ignoreResult | ||
| |> Property.report | ||
|
|
||
| match report.Status with | ||
| | Failed _ -> () | ||
| | _ -> failwith "Expected Failed status" | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.