Security: Overly permissive CSP in online webview enables script injection#498
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
…enables sc The online-mode HTML sets a Content Security Policy with wildcards and `'unsafe-inline'`/`'unsafe-eval'` across `script-src`, `default-src`, `frame-src`, etc. This effectively disables CSP protections in a privileged VS Code webview and makes XSS or third-party script compromise far more impactful. Affected files: DrawioClientFactory.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The online-mode HTML sets a Content Security Policy with wildcards and
'unsafe-inline'/'unsafe-eval'acrossscript-src,default-src,frame-src, etc. This effectively disables CSP protections in a privileged VS Code webview and makes XSS or third-party script compromise far more impactful.Severity:
criticalFile:
src/DrawioClient/DrawioClientFactory.tsSolution
Replace the CSP with a strict policy: lock
script-srcto nonce-based scripts and trusted origins only, removeunsafe-eval, restrictframe-src/connect-srcto explicit allowlists, and disallow wildcard*sources.Changes
src/DrawioClient/DrawioClientFactory.ts(modified)Testing