Conversation
This introduces draw_named as the primitive for when we are actually printing, which provides much nicer output for values. It then makes the hegel::test macro automatically rewrite draw() to draw_named where it is safe to do so.
- Remove explicit 'a lifetime in is_tc_draw_binding (clippy::needless_lifetimes) - Move NOTE text outside ```no_run code fence in draw() doc comment - Allow clippy::let_and_return in closure test (needed for macro rewrite testing) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces draw_named as the primitive for when we are actually printing, which provides much nicer output for values.
It then makes the hegel::test macro automatically rewrite draw() to draw_named where it is safe to do so.
The result is that if you have a test that looks something like:
You will see output like:
If you were to write it like this without the intermediate variable:
You would see:
Users are able to name things directly if they want. It's a bit unergonomic but not awful. e.g.
is equivalent to the first example.