Skip to content

table widget #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions includes/managers/widgets.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ private function init_widgets() {
'common',
'inner-section',
'heading',
'table',
'image',
'text-editor',
'video',
Expand Down
289 changes: 289 additions & 0 deletions includes/widgets/table.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,289 @@
<?php
namespace Elementor;

if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}


use Elementor\Core\Kits\Documents\Tabs\Global_Typography;

/**
* Elementor table widget.
*
*
* @since 1.0.0
*/
class Widget_Table extends Widget_Base {

/**
* Get widget name.
*
* Retrieve table widget name.
*
* @since 1.0.0
* @access public
*
* @return string Widget name.
*/
public function get_name() {
return 'table';
}

/**
* Get widget title.
*
* Retrieve table widget title.
*
* @since 1.0.0
* @access public
*
* @return string Widget title.
*/
public function get_title() {
return esc_html__( 'table', 'elementor' );
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we always use capital letters here:

return esc_html__( 'Table', 'elementor' );

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it

}

/**
* Get widget icon.
*
* Retrieve table widget icon.
*
* @since 1.0.0
* @access public
*
* @return string Widget icon.
*/
public function get_icon() {
return 'eicon-table';
}

/**
* Get widget categories.
*
* Retrieve the list of categories the table widget belongs to.
*
* Used to determine where to display the widget in the editor.
*
* @since 2.0.0
* @access public
*
* @return array Widget categories.
*/
public function get_categories() {
return [ 'basic' ];
}

/**
* Get widget keywords.
*
* Retrieve the list of keywords the widget belongs to.
*
* @since 2.1.0
* @access public
*
* @return array Widget keywords.
*/
public function get_keywords() {
return [ 'table', 'title', 'text' ];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return [ 'table' ];

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the 'title' and the 'text'

}

/**
* Get widget upsale data.
*
* Retrieve the widget promotion data.
*
* @since 3.18.0
* @access protected
*
* @return array Widget promotion data.
*/
protected function get_upsale_data() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete?

Copy link
Author

@Mchris-hub Mchris-hub Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i deleted it

return [
'condition' => ! Utils::has_pro(),
'image' => esc_url( ELEMENTOR_ASSETS_URL . 'images/go-pro.svg' ),
'image_alt' => esc_attr__( 'Upgrade', 'elementor' ),
'description' => esc_html__( 'Create captivating tables that rotate with the Animated Headline Widget.', 'elementor' ),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'description' => esc_html__( 'Create captivating tables.', 'elementor' ),

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the description

'upgrade_url' => esc_url( 'https://go.elementor.com/go-pro-table-widget/' ),
'upgrade_text' => esc_html__( 'Upgrade Now', 'elementor' ),
];
}

/**
* Register table widget controls.
*
* Adds different input fields to allow the user to change and customize the widget settings.
*
* @since 3.1.0
* @access protected
*/
protected function register_controls() {

$this->start_controls_section(
'content_section',
[
'label' => esc_html__( 'Table content', 'elementor' ),
'tab' => \Elementor\Controls_Manager::TAB_CONTENT,
]
);

$this->add_control(
'show_title',
[
'label' => esc_html__( 'Show Columns Titles', 'elementor' ),
'type' => \Elementor\Controls_Manager::SWITCHER,
'label_on' => esc_html__( 'Show', 'elementor' ),
'label_off' => esc_html__( 'Hide', 'elementor' ),
'return_value' => 'yes',
'default' => 'yes',
]
);

$this->add_control(
'column_one',
[
'label' => esc_html__( 'Title column 1', 'elementor' ),
'type' => Controls_Manager::TEXT,
'label_block' => true,
'placeholder' => esc_html__( 'Enter column title', 'elementor' ),
'dynamic' => [
'active' => true,
],
]
);

$this->add_control(
'column_two',
[
'label' => esc_html__( 'Title column 2', 'elementor' ),
'type' => Controls_Manager::TEXT,
'label_block' => true,
'placeholder' => esc_html__( 'Enter column title', 'elementor' ),
'dynamic' => [
'active' => true,
],
]
);
$this->add_control(
'column_three',
[
'label' => esc_html__( 'Title column 3', 'elementor' ),
'type' => Controls_Manager::TEXT,
'label_block' => true,
'placeholder' => esc_html__( 'Enter column title', 'elementor' ),
'dynamic' => [
'active' => true,
],
]
);

$repeater = new repeater();

$repeater->add_control(
'text',
[
'label' => esc_html__( 'Text', 'elementor' ),
'type' => Controls_Manager::TEXT,
'label_block' => false,
'placeholder' => esc_html__( 'List Item', 'elementor' ),
'default' => esc_html__( 'List Item', 'elementor' ),
'dynamic' => [
'active' => true,
],
]
);

$this->add_control(
'list',
[
'label' => esc_html__( 'Columns contents', 'elementor' ),
'show_label' => esc_html__( true, 'elementor' ),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'show_label' => esc_html__( true, 'elementor' ),
'show_label' => true,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it

'type' => \Elementor\Controls_Manager::REPEATER,
'fields' => $repeater->get_controls(),
'default' => [
[
'list_title' => esc_html__( 'Content column 1', 'elementor' ),
'list_content' => esc_html__( 'Item content. Click the edit button to change this text.', 'elementor' ),
],
[
'list_title' => esc_html__( 'Content column 2', 'elementor' ),
'list_content' => esc_html__( 'Item content. Click the edit button to change this text.', 'elementor' ),
],
[
'list_title' => esc_html__( 'Content column 3', 'elementor' ),
'list_content' => esc_html__( 'Item content. Click the edit button to change this text.', 'elementor' ),
],
],

]
);



$this->end_controls_section();
}

/**
* Render table widget output on the frontend.
*
* Written in PHP and used to generate the final HTML.
*
* @since 1.0.0
* @access protected
*/

protected function render() {
$settings = $this->get_settings_for_display();

echo '<table>';
if ( 'yes' === $settings['show_title'] ) {
echo '<thead>';
echo '<tr>';
echo '<th>' . $settings['column_one'] . '</th>';
echo '<th>' . $settings['column_two'] . '</th>';
echo '<th>' . $settings['column_three'] . '</th>';
echo '</tr>';
echo '</thead>';
}

if ( $settings['list'] ) {
echo '<tbody>';
echo '<tr>';
foreach ( $settings['list'] as $item ) {
echo '<td class="elementor-repeater-item-' . esc_attr( $item['_id'] ) . '">' . $item['list_title'] . '</td>';
}
echo '</tr>';
echo '</tbody>';
}
echo '</table>';
}

protected function content_template() {
?>

<table>
<# if ( 'yes' === settings.show_title ) { #>
<thead>
<tr>
<th>{{{ settings.column_one }}}</th>
<th>{{{ settings.column_two }}}</th>
<th>{{{ settings.column_three }}}</th>
</tr>
</thead>
<# } #>

<# if ( settings.list.length ) { #>
<tbody>
<tr>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<tr>

<# _.each( settings.list, function( item ) { #>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<# _.each( settings.list, function( item ) { #>
<# _.each( settings.list, function( item ) { #>
<tr>

<td class="elementor-repeater-item-{{ item._id }}">{{{item.list_title}}}</td>
<# }); #>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<# }); #>

</tr>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</tr>
</tr>
<# }); #>

</tbody>
<# } #>
</table>
<?php
}


}
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"eslint-plugin-no-jquery": "^2.7.0",
"eslint-plugin-react": "^7.33.2",
"eslint-webpack-plugin": "^4.0.1",
"grunt": "^1.5.3",
"grunt": "^1.6.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert to the orginal value. We can't update packages on the whole repository.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes. We can't make updates here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed it

"grunt-banner": "~0.6.0",
"grunt-bumpup": "~0.6.3",
"grunt-checktextdomain": "~1.0.1",
Expand Down