Skip to content

Conversation

@ljnelson
Copy link
Member

@ljnelson ljnelson commented Dec 11, 2025

This PR:

  • Upgrades Narayana to 7.3.3.Final 7.1.0.Final (see comments below)
  • Upgrades jboss-logging to 3.6.1.Final (the version required by Narayana 7.3.3.Final). Note that this is higher than the version Weld 5.1.6.Final (the version our repackaging uses) uses. It does not appear after cursory testing to cause problems, but we'll let the pipelines sort it out. Ensures jboss-logging is at version 3.5.0.Final, used by both our repackaged Weld 5.1.6.Final and Narayana 7.1.0.Final 3.5.3.Final (see comments)
  • Removes an unused? reference to jboss-logging-annotations which may have had a purpose once upon a time but doesn't seem to now.

@ljnelson ljnelson self-assigned this Dec 11, 2025
@ljnelson ljnelson added jpa/jta dependencies Pull requests that update a dependency file 4.x Version 4.x labels Dec 11, 2025
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 11, 2025
@ljnelson
Copy link
Member Author

ljnelson commented Dec 11, 2025

Packaging failures are due to: https://github.com/jboss-logging/jboss-logging/blob/3.6.1.Final/src/main/java/org/jboss/logging/Logger.java#L2572

This is called by, effectively: https://github.com/weld/core/blob/5.1.6.Final/impl/src/main/java/org/jboss/weld/logging/VersionLogger.java#L35 (our Weld repackaging uses a slightly altered version of 5.1.6.Final)

Sample output:

Caused by: java.lang.IllegalArgumentException: This library does not have private access to interface org.jboss.weld.logging.VersionLogger
	at [email protected]/org.jboss.logging.Logger.getMessageLogger(Logger.java:2572)
	at [email protected]/org.jboss.logging.Logger.getMessageLogger(Logger.java:2552)
	at [email protected]/org.jboss.weld.logging.VersionLogger.<clinit>(VersionLogger.java:35)

([email protected] in this run is our repackaged Weld module which as previously noted is actually version 5.1.6.Final.)

@ljnelson
Copy link
Member Author

Upgrading Weld requires repackaging and fixing our rewrite of its proxy machinery. If we decide to do this, that's a whole different PR.

Holding our repackaged Weld version at 5.1.6.Final, our only option is to upgrade to a version of Narayana that still uses jboss-logging at 3.5.0.Final (the same version used by Weld 5.1.6.Final). That version is, broadly, 7.1.2.Final.

However, for whatever reason, a key component of Narayana that we use was never released at 7.1.2.Final. Instead, the most recent compatible release was 7.1.0.Final.

So I'll make this PR be an upgrade to Narayana 7.1.0.Final, where we will be forced to remain until we decide to upgrade and re-re-package Weld, whereupon we should upgrade jboss-logging and Narayana appropriately.

@ljnelson ljnelson changed the title 4.x: Upgrades Narayana to 7.3.3.Final 4.x: Upgrades Narayana to 7.1.0.Final Dec 11, 2025
@ljnelson
Copy link
Member Author

Aligning jboss-logging at 3.5.0.Final, the version required by both Weld 5.1.6.Final and Narayana 7.1.0.Final, causes our modularity tests to fail. Bumping it back to 3.5.3.Final, a rather arbitrary choice, appears to fix them.

…1.Final as required by Narayana. Removes unused reference to jboss-logging-annotations in pom.xml.

Signed-off-by: Laird Nelson <[email protected]>
…with jboss-logging 3.5.0.Final, which is used by Weld 5.1.6.Final and our repackaged version of Weld

Signed-off-by: Laird Nelson <[email protected]>
@ljnelson ljnelson force-pushed the 4.x-10757-upgrade-narayana branch from 57e1038 to 07fb182 Compare January 12, 2026 20:36
@ljnelson
Copy link
Member Author

@tomas-langer gives his approval out-of-band. Merging.

@ljnelson ljnelson merged commit 54c5abe into helidon-io:main Jan 13, 2026
70 checks passed
@ljnelson ljnelson mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x Version 4.x dependencies Pull requests that update a dependency file jpa/jta OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants