-
Notifications
You must be signed in to change notification settings - Fork 590
4.x: Upgrades Narayana to 7.1.0.Final #10900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: Upgrades Narayana to 7.1.0.Final #10900
Conversation
|
Packaging failures are due to: https://github.com/jboss-logging/jboss-logging/blob/3.6.1.Final/src/main/java/org/jboss/logging/Logger.java#L2572 This is called by, effectively: https://github.com/weld/core/blob/5.1.6.Final/impl/src/main/java/org/jboss/weld/logging/VersionLogger.java#L35 (our Weld repackaging uses a slightly altered version of 5.1.6.Final) Sample output: ( |
|
Upgrading Weld requires repackaging and fixing our rewrite of its proxy machinery. If we decide to do this, that's a whole different PR. Holding our repackaged Weld version at 5.1.6.Final, our only option is to upgrade to a version of Narayana that still uses However, for whatever reason, a key component of Narayana that we use was never released at 7.1.2.Final. Instead, the most recent compatible release was 7.1.0.Final. So I'll make this PR be an upgrade to Narayana 7.1.0.Final, where we will be forced to remain until we decide to upgrade and re-re-package Weld, whereupon we should upgrade |
|
Aligning jboss-logging at 3.5.0.Final, the version required by both Weld 5.1.6.Final and Narayana 7.1.0.Final, causes our modularity tests to fail. Bumping it back to 3.5.3.Final, a rather arbitrary choice, appears to fix them. |
…1.Final as required by Narayana. Removes unused reference to jboss-logging-annotations in pom.xml. Signed-off-by: Laird Nelson <[email protected]>
…with jboss-logging 3.5.0.Final, which is used by Weld 5.1.6.Final and our repackaged version of Weld Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
57e1038 to
07fb182
Compare
|
@tomas-langer gives his approval out-of-band. Merging. |
This PR:
7.3.3.Final7.1.0.Final (see comments below)UpgradesEnsuresjboss-loggingto 3.6.1.Final (the version required by Narayana 7.3.3.Final). Note that this is higher than the version Weld 5.1.6.Final (the version our repackaging uses) uses. It does not appear after cursory testing to cause problems, but we'll let the pipelines sort it out.jboss-loggingis at version3.5.0.Final, used by both our repackaged Weld 5.1.6.Final and Narayana 7.1.0.Final3.5.3.Final (see comments)jboss-logging-annotationswhich may have had a purpose once upon a time but doesn't seem to now.