Tried to make the bundle SF4 compatible #147
Conversation
The tests are still failing because of faulty config
ghost
changed the title
|
Thanks for this work, ill try to check this on weekend. |
|
I'm currently using this dev version on a personal project of mine and it seems to work as expected (at least for |
alquerci
left a comment
alquerci
left a comment
There was a problem hiding this comment.
@helios-ag I made a quick review about only important things.
| { | ||
| $result = new Decoda(); | ||
| } | ||
|
|
There was a problem hiding this comment.
What is the reason to delete this case?
The assertion here is that no exception is thrown.
There was a problem hiding this comment.
You are not testing anything, since the constructor will never throw an error. In fact, why is third party code being tested? Also, PHPUnit sees it as a risky test, since nothing happens inside the test.
|
|
||
| $result = new EmoticonHook($loader, $container); | ||
| } | ||
|
|
There was a problem hiding this comment.
What is the reason to delete this case?
The assertion here is that no exception is thrown.
| public: true | ||
| tags: | ||
| - { name: fm_bbcode.decoda.filter, id: table } | ||
|
|
There was a problem hiding this comment.
This duplicate service definition on Resources/config/filters.xml.
There was a problem hiding this comment.
Hmmm, I think I missed something somewhere. Pretty sure it was required for some reason, will look into it.
|
|
||
| if (!file_exists($emoticonsFolder) && !is_dir($emoticonsFolder)) { | ||
| return $output->writeln('<error>Emoticons folder does not exist</error>'); | ||
| $output->writeln('<error>Emoticons folder does not exist</error>'); |
There was a problem hiding this comment.
The return is expected here in order to stop the task execution here as the source folder does not exists.
There was a problem hiding this comment.
The return value inside execute should return something useful or nothing at all. Returning the output of $output->writeln() is not related to your command (in fact it doesn't even return anything).
However, I'll add it again (below $output->writeln()) it since it is indeed required for proper execution.
3 participants
@helios-ag since I want to update one of my applications, I had to upgrade this bundle to Symfony4, so I did. I made some tiny codestyle changes and fixed few things here and there.
Major points are that the
sensio/distribution-bundlewon't be supported for Symfony4 andsymfony/assetic-bundleis deprecated. I've just added apublic_pathsincesymfony/assetic-bundlewas only required for it's output path (as far as I could see). Thepublic_pathdefaults to the SF4 default for the web folder (which is/public).If you want me to test anything else or got any feedback, let me know.