This repository was archived by the owner on Dec 19, 2025. It is now read-only.
Fix parser tests for whitespace sensitivity (#8) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SyntaxKind::Indent to LHS_KINDS so indented expressions are properly parsed instead of being treated as errors - Convert test() to test_parse_indented_continuation with proper expect assertions for whitespace-sensitive parsing
- Remove erroneous p.expect(Newline) from global_binding since Newline is treated as trivia and automatically attached to expressions - Uncomment and enable test_parse_multiple_declarations test
Enable and update the test for parsing binary expressions with interspersed comments and nested indentation. The expected output reflects the correct handling of Exp_Indented nodes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
expr.rs: AddSyntaxKind::IndenttoLHS_KINDS, fixtest_parse_indented_continuationdecl.rs: Removep.expect(Newline)since it's handled as triviagrammar.rs: Enabletest_parse_multiple_declarationsexpr.rs: Enabletest_parse_binary_expression_interspersed_with_commentsTest plan
Exp_IndentednodesCloses #8