Added reward type to the Reward model#292
Open
andreiguzga wants to merge 1 commit intohelium:masterfrom
Open
Conversation
Author
|
Any chance someone can take a look at this PR? I would like to prepare our platform to be compatible with the new switch to light hotspots and we are blocked by not having the reward type on the rewards endpoint. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to move from the activity endpoint and use the new rewards endpoint but this was missing the type of the reward. I've noticed that the type of the reward was added in the API but it is not reflected in this library.
I am working on updating my platform to be compatible with the new changes that the light hotspots will add to validators and I need to know the types of rewards when fetching them through this library.