Remove payer from pack #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to pass in payer, we can just use Pubkey::default to get transaction lengths for packing
There was a problem hiding this comment.
Pull Request Overview
This PR removes the payer parameter from transaction packing functions and related calls, using Pubkey::default wherever applicable.
- Removed the explicit payer parameter from pack_instructions_into_transactions in both client and transaction utilities.
- Updated calls to task bundle functions in the queue module by eliminating the payer reference.
- Modified construction of transactions in solana-transaction-utils to rely on default pubkeys instead of an explicit payer.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tuktuk-cli/src/cmd/task.rs | Removed the payer parameter when packing instructions. |
| tuktuk-cli/src/client.rs | Updated to pass None for payer when creating transactions. |
| solana-transaction-utils/src/queue.rs | Eliminated the payer parameter from task bundle additions. |
| solana-transaction-utils/src/pack.rs | Removed the payer parameter from several functions and updated usages to utilize Pubkey::default. |
ChewingGlass
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to pass in payer, we can just use Pubkey::default to get transaction lengths for packing